Minoka's eventstream puzzler draft #34
Draft
+338
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minoka event stream puzzler
function written and working well
DuHerb
reviewed
Jun 8, 2022
DuHerb
reviewed
Jun 8, 2022
DuHerb
reviewed
Jun 8, 2022
src/index.test.ts
Outdated
| expect(true).toBeTruthy() | ||
| describe('Event scoring function tests.', () => { | ||
|
|
||
| describe('Tests for getting the highest scoring region in a event stream', () => { |
There was a problem hiding this comment.
describe text should just be the function being tested. getHighestScoringRegions
There was a problem hiding this comment.
the it blocks describe exactly how the described function is being tested in each case.
src/index.test.ts
Outdated
| }) | ||
| }) | ||
|
|
||
| describe('Tests for getting the total score of each region', () => { |
There was a problem hiding this comment.
same. describe string should be function name.
src/index.test.ts
Outdated
| }) | ||
| }) | ||
|
|
||
| describe('Test for getting the correct score for each event', () => { |
DuHerb
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Ticket:
Issue #none
2. What this does:
3. Media:
4. How to test:
pull down code and run
yarn test