Convert UserAPI to Typescript #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…array of Persons. added types to each parameter
rachoac
reviewed
May 23, 2022
rachoac
reviewed
May 23, 2022
rachoac
reviewed
May 23, 2022
…pread out and reassign array.
DuHerb
requested changes
May 23, 2022
DuHerb
reviewed
May 23, 2022
DuHerb
reviewed
May 24, 2022
src/index.ts
Outdated
| const targetUser = this.list.find(user => user.id === id) | ||
| if (!targetUser) { | ||
| throw new Error("There are no users found with that id.") | ||
| } | ||
| return targetUser | ||
| } | ||
|
|
||
| updateUserById(updatedUser) { | ||
| updateUserById(updatedUser: Person): Person { |
There was a problem hiding this comment.
updatedUserById should accept:
a) a user ID for lookup
b) fields to be updated
lookup the TS Utility Partial, or just create a new object with fields that may be updated.
There was a problem hiding this comment.
@rachoac should this be refactored to actually update the found Person object here, rather than accepting a whole, new Person? @kakizaki55 and I have discussed 1-1 in zoom, so maybe not necessary to practice that pattern here.
…ter to updateuser and updated test accordingly.
…et the first test to pass.
…tUsersById so test are passing.
…o work on error handling of update user by id.
… delete user. .filter for search by name.
User stats methods
Convert to Record Object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What this does:
2. Ticket:
Issue #none
3. Media:
4. How to test:
pull down code run
yarn jest --watch