Convert UserAPI to Typescript #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kakizaki55 wants to merge 38 commits into minoka-development from convert-to-typescript

kakizaki55 commented May 20, 2022 •

edited

Loading

1. What this does:

Added interface for the Person to use as the user Type.
Each method has an argument type and return type.
Each Array is of type ReadonlyArray
had to make changes to line 23, to reassign the array so the Array stays unmutated.
added UserFormMeta interface to add user and update user arguments. (id is not optional)
updateUser now takes 2 arguments (id, UserFormMeta), Updated Tests accordingly.

2. Ticket:
Issue #none

3. Media:

UserFormMeta interface

unit tests

4. How to test:
pull down code run yarn jest --watch

kakizaki55 added 4 commits

May 20, 2022 15:14


          added an interface for a Persona and declared the type of list as an …

2959e53

…array of Persons. added types to each parameter


          added return types to methods.

e9c46b5


          added return types for each method.

d3746c9


          added readonly to all types in Person interface

93a21a8

kakizaki55 closed this

kakizaki55 added 4 commits

May 23, 2022 14:30


          Merge branch 'minoka-development' into convert-to-typescript

5a25848


          Merge branch 'minoka-development' into convert-to-typescript

1511f4e


          added Error as return types as well as empty [].

40db008


          getting rid of comment

7ac2bf4

kakizaki55 reopened this

kakizaki55 changed the base branch from master to minoka-development

May 23, 2022 22:01

rachoac reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved


          getting rid of retunr type Error

df2131e

rachoac reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

rachoac reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved


          changed Arrays to ReadonlyArrays type. and had to change line 23 to s…

4eece1c

…pread out and reassign array.

DuHerb requested changes

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

DuHerb reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

DuHerb reviewed

View reviewed changes

src/index.ts Outdated

    
                }

                updateUserById(updatedUser) {

                updateUserById(updatedUser: Person): Person {

DuHerb May 24, 2022

updatedUserById should accept:
a) a user ID for lookup
b) fields to be updated

lookup the TS Utility Partial, or just create a new object with fields that may be updated.

DuHerb May 24, 2022

@rachoac should this be refactored to actually update the found Person object here, rather than accepting a whole, new Person? @kakizaki55 and I have discussed 1-1 in zoom, so maybe not necessary to practice that pattern here.

kakizaki55 added 11 commits

May 24, 2022 09:33


          added UserFormMeta type for add user argument

15adc57


          Added UserFromMeta type for adding and updating user. added id parama…

2c5f20e

…ter to updateuser and updated test accordingly.


          typed the mock users as a Record obj, fixed addUser and getUsers to g…

2555f78

…et the first test to pass.


          changed mockUsers from function to just an object. made changes to ge…

8b80772

…tUsersById so test are passing.


          updated deleteUser by id for object model. test passing. still need t…

8515dc0

…o work on error handling of update user by id.


          searchByName function refactored for obj model

2b3a210


          refactrored getusers to use object.entires()

e5a9614


          fixed update bu user Id and spaceing.

22269f3


          opps forgot to push this one, made a utils file for the interfaces

193425d


          used the User interface instead of Record


          getUserById refactored to user a map. still need to type .map

b46da91

kakizaki55 added 17 commits

May 25, 2022 10:03


          Typed getUserById map invocation all variables seem to have types

e3cadca


          refactored getUsers to user .map and typed

80a12be


          worked with dustin, to use .map for getUsers spread op for update and…

021bbc7

… delete user. .filter for search by name.


          test Written for gettig average age

41b6b9f


          getAverageAge works but its kinda smelly. need to refactor

f8ef369


          some refactoring, still needs work.

4445b36


          test written for geting all favorite colors.

89ee1c7


          made two function getAllFavoriteColors, and getAllFavoriteColorBy Nam…

3cd001f

…e test passing.


          refactored getAverageAge. refactored getAllColors to use a new Set() …

f2a1ba7

…no dupes


          fixed minor typo

35c5d6e


          working but need to figure out typeing for useing bracket notation.

a9fd28f


          getfavorite Color Count refactored.

7e29fab


          getUserMeta method all done. test passing.

bc42318


          typed the retrun for getUserMeta

3ce60b8


          spacing

b301823


          Merge pull request #24 from olioapps/user-stats-methods

a7fd620

User stats methods


          Merge pull request #23 from olioapps/convert-to-Record

90c703c

Convert to Record Object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet