EventScoreAPI #11
Open
EventScoreAPI #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianandrewson
reviewed
Jan 3, 2022
|
|
||
| describe('EventScore API', () => { | ||
| it('Returns an entire array if it is five events or less', () => { |
There was a problem hiding this comment.
Might be worth having tests for edge cases: arrays of length 0 and 5.
src/index.ts
Outdated
| } else tempCount += 1 | ||
|
|
||
| if (i > 4) { | ||
| if (eventType[i - 1] === "screenshot") { |
There was a problem hiding this comment.
Are you sure you want to subtract from tempCount the most recent value added?
| } else { | ||
| this.eventArr.map((event, i) => { | ||
| const { eventType } = event | ||
| if (eventType === "screenshot") { |
There was a problem hiding this comment.
Yup, can definitely refactor the conversion of eventType to a scoring value.
|
|
||
| public calcHighestScoreArrSequence = (): ReadonlyArray<Event> => { | ||
| let tempCount: number = 0 | ||
| let highestScoreArr: ReadonlyArray<Event> = [] |
There was a problem hiding this comment.
While insignificant in this case, as highestScoreArr is going to have max length of 5, it is possible to solve this without storing the returned highestScoreArr, and instead just directly return it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does: