[ADD] estate: Added a new module named estate #733

msho-odoo · 2025-04-22T16:46:22Z

No description provided.

robodoo · 2025-04-22T16:46:24Z

SergeBayet · 2025-04-23T07:15:26Z

estate/__manifest__.py

+    'installable': True,
+    'application': True,
+    'auto_install': False
+}


Don't forget the license key to avoid warnings in the log.

SergeBayet · 2025-04-23T07:31:36Z

@msho-odoo For the title of the commit, be aware that the commit message header should make a valid sentence once concatenated with if applied, this commit will header. For example [IMP] base: prevent to archive users linked to active partners is correct as it makes a valid sentence if applied, this commit will prevent users to archive....
Don't use uppercase for the title.

[ADD] estate: add a new estate property module for example.

src: https://www.odoo.com/documentation/18.0/contributing/development/git_guidelines.html#commit-message-header

…oprty

…in UI

SergeBayet · 2025-04-23T09:28:27Z

estate/__manifest__.py

+    'data': [
+        'security/ir.model.access.csv',
+        'views/estate_property_views.xml',
+        'views/estate_menu.xml',
+            ],


Suggested change

'data': [

'security/ir.model.access.csv',

'views/estate_property_views.xml',

'views/estate_menu.xml',

],

'data': [

'security/ir.model.access.csv',

'views/estate_property_views.xml',

'views/estate_menu.xml',

],

SergeBayet · 2025-04-23T09:29:07Z

estate/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_estate_property, access_estate_property,model_estate_property,base.group_user,1,1,1,1


SergeBayet · 2025-04-23T09:29:19Z

estate/views/estate_menu.xml

+            <menuitem id="estate_property_action_menu" action="estate_property_action"></menuitem>
+        </menuitem>
+    </menuitem>
+</odoo>


SergeBayet · 2025-04-23T09:29:23Z

estate/views/estate_property_views.xml

+        <field name="res_model">estate.property</field>
+        <field name="view_mode">list,form</field>
+    </record>
+</odoo>


@SergeBayet Noted.
I fixed linting and EOF problems

SergeBayet · 2025-04-23T10:43:30Z

…perty manifest

SergeBayet · 2025-04-23T11:15:55Z

estate/models/estate_property.py

@@ -10,7 +10,7 @@ class EstateProperty(models.Model):
    description = fields.Text('description')
    postcode = fields.Char('postcode')
    date_availability = fields.Date(
-        'availabilty date', copy=False, default=fields.Date.today()+relativedelta(months=3))
+        'availabilty date', copy=False, default=fields.Date.today() + relativedelta(months=3))


For this diff you could use git commit --amend to correct the previous commit :)

@SergeBayet
yes, I wasn't used to using it in that sense but sure it makes sense.
Thank you for pointing these things out, it helps :)

…ty search

SergeBayet · 2025-04-24T07:33:18Z

estate/models/estate_property.py

@@ -37,3 +37,5 @@ class EstateProperty(models.Model):
        "res.users", string="Salesperson", default=lambda self: self.env.user)
    buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False)
    tag_ids = fields.Many2many("estate.property.tag", string="Tags")
+    offer_ids = fields.One2many(
+        "estate.property.offer", "property_id", string="Offers")


Silly little remark, but choose if you want to use double quotes or single quotes and stick to it :) In Python, this kind of convention depends of the team you'll be in.

…rty_offer

SergeBayet

Some remarks :)

SergeBayet · 2025-04-24T09:31:23Z

estate/models/estate_property.py

+
+    @api.depends("offer_ids")
+    def _compute_best_offer(self):
+        try:


Why this try/except block? What could happen?

It was giving me some error but I fixed it later, removing it

SergeBayet · 2025-04-24T09:33:13Z

estate/models/estate_property.py

+                if len(record.offer_ids) > 0:
+                    record.best_offer = max(record.offer_ids.mapped("price"))
+                else:
+                    record.best_offer = 0.0


A more pyhtonic way:

for prop in self: prop.best_price = max(prop.offer_ids.mapped("price")) if prop.offer_ids else 0.0

SergeBayet · 2025-04-24T09:36:00Z

estate/models/estate_property_offer.py

+    date_deadline = fields.Date(
+        compute="_compute_date_deadline", inverse="_inverse_date_deadline")
+
+    @api.depends("validity")


It depends of create_date too, isn't it?

SergeBayet · 2025-04-24T09:37:28Z

estate/models/estate_property_offer.py

+        for record in self:
+            start_date = fields.Date.today()
+            if record.create_date:
+                start_date = record.create_date


Be aware that record.create_date is a DateTime field. You can extract the date with the method date()
So maybe this could be better:

for offer in self: date = offer.create_date.date() if offer.create_date else fields.Date.today() offer.date_deadline = date + relativedelta(days=offer.validity)

SergeBayet · 2025-04-24T09:37:44Z

estate/models/estate_property_offer.py

+        for record in self:
+            start_date = fields.Date.today()
+            if record.create_date:
+                start_date = record.create_date


Same than above.

SergeBayet · 2025-04-24T10:30:11Z

estate/models/estate_property_offer.py

+
+    def _inverse_date_deadline(self):
+        for record in self:
+            start_date = fields.Date.today()


start_date is never used...

SergeBayet · 2025-04-24T11:48:23Z

@vava-odoo You can take over this one. :) Thanks

vava-odoo · 2025-04-24T12:01:48Z

@SergeBayet I don't review red runbot PRs 😇
cc @msho-odoo

msho-odoo · 2025-04-24T13:35:02Z

@vava-odoo
the runbot is green now :)

vava-odoo

A few comments passing by. Good luck with next chapters 💪

vava-odoo · 2025-04-24T13:37:27Z

estate/__manifest__.py

+    ],
+    'installable': True,
+    'application': True,
+    'auto_install': False,


Default value are not needed (in community, this would raise a warning in runbot)

Suggested change

'auto_install': False,

vava-odoo · 2025-04-24T13:37:46Z

estate/models/estate_property.py

@@ -0,0 +1,81 @@
+from odoo import api, fields, models
+from odoo.exceptions import UserError
+from dateutil.relativedelta import relativedelta


Guideline: external import first

vava-odoo · 2025-04-24T13:38:01Z

estate/models/estate_property.py

+
+class EstateProperty(models.Model):
+    _name = "estate.property"
+    _description = "Estate Property discription"


discription 👀

vava-odoo · 2025-04-24T13:38:57Z

estate/models/estate_property.py

+        selection=[('north', 'North'), ('south', 'South'),
+                   ('east', 'East'), ('west', 'West')]


usually we indent a bit differently

Suggested change

selection=[('north', 'North'), ('south', 'South'),

('east', 'East'), ('west', 'West')]

selection=[

('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West'),

],

vava-odoo · 2025-04-24T13:39:34Z

estate/models/estate_property.py

+    property_type_id = fields.Many2one(
+        "estate.property.type", string="property type")


We avoid long lines, but don't be extreme. Here a one-liner is fine

Suggested change

property_type_id = fields.Many2one(

"estate.property.type", string="property type")

property_type_id = fields.Many2one("estate.property.type", string="property type")

vava-odoo · 2025-04-24T13:40:18Z

estate/models/estate_property.py

+            record.best_offer = max(record.offer_ids.mapped(
+                "price")) if record.offer_ids else 0.0


Could use default kwarg

Suggested change

record.best_offer = max(record.offer_ids.mapped(

"price")) if record.offer_ids else 0.0

record.best_offer = max(record.offer_ids.mapped("price"), default=0.0)

vava-odoo · 2025-04-24T13:40:51Z

estate/models/estate_property.py

+
+    @api.onchange("garden")
+    def _onchange_garden(self):
+        if self.garden:


I'd say has_garden is a clearer name, but that is debatable

agree, just for the sake of the tutorial

vava-odoo · 2025-04-24T13:41:51Z

estate/models/estate_property.py

+        for record in self:
+            if record.state == "cancelled":
+                raise UserError("You can't sell a cancelled property")
+            record.state = "sold"


Better to raise first and assign in batch. For example:

Suggested change

for record in self:

if record.state == "cancelled":

raise UserError("You can't sell a cancelled property")

record.state = "sold"

if "cancelled" in record.mapped('state'):

raise UserError("You can't sell a cancelled property")

self.state = "sold"

vava-odoo · 2025-04-24T13:44:14Z

estate/views/estate_property_type_views.xml

+        <field name="name">properties.view.type.form</field>
+        <field name="model">estate.property.type</field>
+        <field name="arch" type="xml">
+            <form string="properties type from">


typo

Suggested change

<form string="properties type from">

<form string="properties type form">

Do you need to define this view? I think a default one is automatically created, and not quite different

yes you're right.
I was following the tutorial in case I would add something later to the view, so I did it

vava-odoo · 2025-04-24T13:45:07Z

estate/views/estate_property_views.xml

+                <field name="expected_price"/>
+                <field name="selling_price"/>
+                <field name="availability_date"/>
+                <filter string="Available" name="state" domain="['|',('state','=','new'),('state','=','offer_received')]"/>


Simpler:

Suggested change

<filter string="Available" name="state" domain="['|',('state','=','new'),('state','=','offer_received')]"/>

<filter string="Available" name="state" domain="[('state', 'in', ['new', 'offer_received'])]"/>

…fpr offers

… views

vava-odoo

Few comments passing by your PR 🙂

vava-odoo · 2025-04-28T14:02:17Z

estate/models/estate_property_offer.py

+    @api.model
+    def create(self, vals):
+        property_record = self.env["estate.property"].browse(vals["property_id"])
+        if vals["price"] < property_record.best_offer:


Pay attention that price is not required, you need to handle cases where it is not defined

@vava-odoo
I made a sql constraint on the price so it can't be left empty or 0

vava-odoo · 2025-04-28T14:03:20Z

estate/models/estate_property_offer.py

+    @api.model
+    def create(self, vals):


We tend to prefer recordset over single records in odoo, could you try to adapt this to support multiple-records creation?

vava-odoo · 2025-04-28T14:03:41Z

estate/models/estate_property_tag.py

+    _name = "estate.property.tag"
+    _description = "Estate property tag"
+    _sql_constraints = [
+        ("check_unique_name", "UNIQUE(name)", "Property tag must be unqie")


vava-odoo · 2025-04-28T14:05:04Z

estate/views/estate_property_views.xml

+                <header>
+                    <button name="action_sell" type="object" string="Mark as Sold" invisible="state in ['sold', 'cancelled']"/>
+                    <button name="action_cancel" type="object" string="Cancel" invisible="state in ['sold', 'cancelled']"/>
+                    <field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold"/>


is statusbar_visible necessary when you use all values of the selection field?

@vava-odoo
There is also "cancelled", but the request was to show only those states

vava-odoo · 2025-04-28T14:05:34Z

estate_account/__manifest__.py

+    'name': 'Estate Account',
+    'depends':
+        ['estate', 'account'],
+    'data': [],


no need 🤷

Suggested change

'data': [],

vava-odoo · 2025-04-28T14:05:59Z

estate_account/__manifest__.py

+    'installable': True,
+    'application': True,


Ok, but would be nice to have it installed as soon as dependency modules are

@vava-odoo
makes sense.
Great comments 👍

[ADD] estate: Added a new module named estate

b027a64

msho-odoo added 2 commits April 22, 2025 19:01

[FIX] estate: fixed the name of the module to Real Estate

b33bf48

[IMP] estate: created a model for estate_property in db

329a381

msho-odoo force-pushed the 18.0-add-module-estate-msho branch from a35abec to 329a381 Compare April 22, 2025 20:22

SergeBayet suggested changes Apr 23, 2025

View reviewed changes

[FIX] estate: added a licence key in manifest

078c258

msho-odoo added 2 commits April 23, 2025 10:16

[IMP] estate: give all right access to base group user for estate_ pr…

c9b1dec

…oprty

[IMP] estate: add root menu and action menu views for estate propery …

365d986

…in UI

SergeBayet suggested changes Apr 23, 2025

View reviewed changes

msho-odoo added 2 commits April 23, 2025 11:51

[IMP] estate: add new fields and fileds default values to property form

0c863ac

[FIX] estate: fix linting and EOF in xml and csv files

4bd1002

[FIX] estate: add whitespace around arithmetic operator in estate pro…

450100a

…perty manifest

msho-odoo force-pushed the 18.0-add-module-estate-msho branch from 6f5effe to 450100a Compare April 23, 2025 11:13

SergeBayet reviewed Apr 23, 2025

View reviewed changes

msho-odoo added 4 commits April 23, 2025 14:44

[IMP] estate: add custom filters and group by fields to estate proper…

8ae30b8

…ty search

[IMP] estate: add a new model estate_property_type

8eb5b37

[IMP] estate: add a new model estate_property_tag

9b71df7

[IMP] estate: add a new model estate_property_offer

f09e8e4

SergeBayet approved these changes Apr 24, 2025

View reviewed changes

[IMP] estate: add compute fields for estate_property and estate_prope…

1120d88

…rty_offer

SergeBayet suggested changes Apr 24, 2025

View reviewed changes

msho-odoo force-pushed the 18.0-add-module-estate-msho branch 2 times, most recently from eec66c2 to 658e49e Compare April 24, 2025 11:33

[IMP] estate: added accept and refuse offer buttons

fc150fb

msho-odoo force-pushed the 18.0-add-module-estate-msho branch from 658e49e to fc150fb Compare April 24, 2025 13:06

vava-odoo reviewed Apr 24, 2025

View reviewed changes

msho-odoo force-pushed the 18.0-add-module-estate-msho branch from c011c65 to 8ebd0af Compare April 24, 2025 17:03

msho-odoo added 2 commits April 25, 2025 10:26

[IMP] estate: add sql and python constraints to estate_property

538ac8c

[IMP] estate: add default search for estate_property and stat button …

4c98e9d

…fpr offers

msho-odoo force-pushed the 18.0-add-module-estate-msho branch from 8ebd0af to a3d2623 Compare April 28, 2025 08:55

[IMP] estate: add inherit model for res_users and link offers to user…

57d42f0

… views

msho-odoo force-pushed the 18.0-add-module-estate-msho branch from a3d2623 to 57d42f0 Compare April 28, 2025 09:10

[IMP] estate: create invoices for sold properties

8acd0f1

vava-odoo reviewed Apr 28, 2025

View reviewed changes

[IMP] estate: add kanban view to estate_property

83aa04c

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		access_estate_property, access_estate_property,model_estate_property,base.group_user,1,1,1,1

		selection=[('north', 'North'), ('south', 'South'),
		('east', 'East'), ('west', 'West')]

		property_type_id = fields.Many2one(
		"estate.property.type", string="property type")

	property_type_id = fields.Many2one(
	"estate.property.type", string="property type")
	property_type_id = fields.Many2one("estate.property.type", string="property type")

		record.best_offer = max(record.offer_ids.mapped(
		"price")) if record.offer_ids else 0.0

	<form string="properties type from">
	<form string="properties type form">

	<filter string="Available" name="state" domain="['\|',('state','=','new'),('state','=','offer_received')]"/>
	<filter string="Available" name="state" domain="[('state', 'in', ['new', 'offer_received'])]"/>

[ADD] estate: Added a new module named estate #733

Are you sure you want to change the base?

[ADD] estate: Added a new module named estate #733

Conversation

msho-odoo commented Apr 22, 2025

robodoo commented Apr 22, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergeBayet commented Apr 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msho-odoo Apr 23, 2025 • edited Loading

Choose a reason for hiding this comment

SergeBayet commented Apr 23, 2025

Choose a reason for hiding this comment

msho-odoo Apr 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergeBayet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergeBayet commented Apr 24, 2025

vava-odoo commented Apr 24, 2025

msho-odoo commented Apr 24, 2025

vava-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vava-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergeBayet commented Apr 23, 2025 •

edited

Loading

msho-odoo Apr 23, 2025 •

edited

Loading

msho-odoo Apr 23, 2025 •

edited

Loading