[IMP] estate: add sql and python constraints to estate_property

Author: msho-odoo

estate/__manifest__.py

@@ -12,6 +12,5 @@
     ],
     'installable': True,
     'application': True,
-    'auto_install': False,
     'license': 'AGPL-3',
 }

estate/models/estate_property.py

@@ -1,17 +1,24 @@
-from odoo import api, fields, models
-from odoo.exceptions import UserError
 from dateutil.relativedelta import relativedelta
+from odoo import api, fields, models
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare, float_is_zero
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
-    _description = "Estate Property discription"
+    _description = "Estate property"
+    _sql_constraints = [
+        ("check_expected_price", "CHECK(expected_price > 0)",
+         "The expected price must be strictly positive"),
+        ("check_sell_price", "CHECK(selling_price > 0)",
+         "The selling price of a property must be positive")
+    ]
 
     name = fields.Char('name', required=True)
     description = fields.Text('description')
     postcode = fields.Char('postcode')
-    availability_date = fields.Date(
-        'availabilty date', copy=False, default=fields.Date.today() + relativedelta(months=3))
+    availability_date = fields.Date('availabilty date', copy=False,
+                                    default=fields.Date.today() + relativedelta(months=3))
     expected_price = fields.Float('expected price', required=True)
     selling_price = fields.Float('selling price', readonly=True, copy=False)
     bedrooms = fields.Integer('bedrooms', default=2)
@@ -22,25 +29,31 @@ class EstateProperty(models.Model):
     garden_area = fields.Integer('garden area')
     garden_orientation = fields.Selection(
         string='Garden Orientation',
-        selection=[('north', 'North'), ('south', 'South'),
-                   ('east', 'East'), ('west', 'West')]
+        selection=[
+            ('north', 'North'),
+            ('south', 'South'),
+            ('east', 'East'),
+            ('west', 'West')
+        ],
     )
     active = fields.Boolean('active', default=True)
     state = fields.Selection(
         string='State',
-        selection=[('new', 'New'), ('offer_received', 'Offer Received'),
-                   ('offer_accepted', 'Offer Acccepted'), ('sold', 'Sold'),
-                   ('cancelled', 'Cancelled')],
-        default="new"
+        selection=[
+            ('new', 'New'),
+            ('offer_received', 'Offer Received'),
+            ('offer_accepted', 'Offer Acccepted'),
+            ('sold', 'Sold'),
+            ('cancelled', 'Cancelled')
+        ],
+        default="new",
     )
-    property_type_id = fields.Many2one(
-        "estate.property.type", string="property type")
-    user_id = fields.Many2one(
-        "res.users", string="Salesperson", default=lambda self: self.env.user)
+    property_type_id = fields.Many2one("estate.property.type", string="property type")
+    user_id = fields.Many2one("res.users", string="Salesperson",
+                              default=lambda self: self.env.user)
     buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False)
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
-    offer_ids = fields.One2many(
-        "estate.property.offer", "property_id", string="Offers")
+    offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
     total_area = fields.Integer(compute='_compute_total_area')
     best_offer = fields.Float(compute="_compute_best_offer")
 
@@ -52,8 +65,7 @@ def _compute_total_area(self):
     @api.depends("offer_ids")
     def _compute_best_offer(self):
         for record in self:
-            record.best_offer = max(record.offer_ids.mapped(
-                "price")) if record.offer_ids else 0.0
+            record.best_offer = max(record.offer_ids.mapped("price"), default=0.0)
 
     @api.onchange("garden")
     def _onchange_garden(self):
@@ -65,17 +77,21 @@ def _onchange_garden(self):
             self.garden_orientation = None
 
     def action_sell(self):
-        for record in self:
-            if record.state == "cancelled":
-                raise UserError("You can't sell a cancelled property")
-            record.state = "sold"
-
+        if "cancelled" in self.mapped('state'):
+            raise UserError("You can't sell a cancelled property")
+        self.state = "sold"
         return True
 
     def action_cancel(self):
-        for record in self:
-            if record.state == "sold":
-                raise UserError("You can't cancel a sold property")
-            record.state = "cancelled"
+        if "sold" in self.mapped('state'):
+            raise UserError("You can't cancel a sold property")
+        self.state = "Cancelled"
 
         return True
+
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price(self):
+        for record in self:
+            if not float_is_zero(record.selling_price, 2) and \
+                float_compare(record.selling_price, 0.9*record.expected_price, 2) < 0:
+                raise ValidationError("The selling price has to be at least 90% of the expected price")

estate/models/estate_property_offer.py

@@ -1,22 +1,27 @@
+from dateutil.relativedelta import relativedelta
 from odoo import api, models, fields
 from odoo.exceptions import UserError
-from dateutil.relativedelta import relativedelta
 
 
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
-    _description = "Estate property offer description"
+    _description = "Estate property offer"
+    _sql_constraints = [
+        ("check_price", "CHECK(price > 0)","The offer price must be strictly positive")
+    ]
 
     price = fields.Float('price')
     status = fields.Selection(
         string='status',
-        selection=[('accepted', 'Accepted'), ('refused', 'Refused')]
+        selection=[
+            ('accepted', 'Accepted'),
+            ('refused', 'Refused')
+        ],
     )
     partner_id = fields.Many2one('res.partner', required=True)
     property_id = fields.Many2one('estate.property', required=True)
     validity = fields.Integer(default=7)
-    date_deadline = fields.Date(
-        compute="_compute_date_deadline", inverse="_inverse_date_deadline")
+    date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline")
 
     @api.depends("validity", "create_date")
     def _compute_date_deadline(self):

estate/models/estate_property_tag.py

@@ -3,6 +3,9 @@
 
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
-    _description = "Estate property tag description"
+    _description = "Estate property tag"
+    _sql_constraints = [
+        ("check_unique_name", "UNIQUE(name)", "Property tag must be unqie")
+    ]
 
     name = fields.Char('name', required=True)

estate/models/estate_property_type.py

@@ -3,6 +3,9 @@
 
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
-    _description = "Estate property type description"
+    _description = "Estate property type"
+    _sql_constraints = [
+        ("check_unique_name", "UNIQUE(name)","Property type name must be unqie")
+    ]
 
     name = fields.Char('name', required=True)

estate/views/estate_property_type_views.xml

@@ -19,7 +19,7 @@
         <field name="name">properties.view.type.form</field>
         <field name="model">estate.property.type</field>
         <field name="arch" type="xml">
-            <form string="properties type from">
+            <form string="properties type form">
                 <sheet>
                     <h1>
                         <field name="name"/>

estate/views/estate_property_views.xml

@@ -89,7 +89,7 @@
                 <field name="expected_price"/>
                 <field name="selling_price"/>
                 <field name="availability_date"/>
-                <filter string="Available" name="state" domain="['|',('state','=','new'),('state','=','offer_received')]"/>
+                <filter string="Available" name="state" domain="[('state','in',['new', 'offer_received'])]"/>
                 <group expand="1" string="Group By">
                     <filter string="Postcode" name="postcode" context="{'group_by':'postcode'}"/>
                 </group>