[IMP] Taxes: improve tax configuration doc #15061
Conversation
|
|
|
This PR targets saas-18.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
b54df6d to
6a5f0ab
Compare
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
3 times, most recently
from
5e7cd13 to
10b62eb
Compare
|
@antoine162 @xpl-odoo this forward port of #14908 is awaiting action (not merged or closed). |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
2 times, most recently
from
40889e4 to
19ca404
Compare
|
@antoine162 @xpl-odoo this forward port of #14908 is awaiting action (not merged or closed). |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
2 times, most recently
from
66ba58a to
4bd5b04
Compare
|
@antoine162 @xpl-odoo WARNING: the update of #15060 to c28f72b has caused a conflict in this pull request, data may have been lost. stdout: |
|
@antoine162 @xpl-odoo WARNING: the latest change (4bd5b04) triggered a conflict when updating the next forward-port (#15062), and has been ignored. You will need to update this pull request differently, or fix the issue by hand on #15062. |
|
@antoine162 @xpl-odoo this forward port of #14908 is awaiting action (not merged or closed). |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
4bd5b04 to
e923346
Compare
|
@antoine162 @xpl-odoo WARNING: the update of #15060 to a7ab458 has caused a conflict in this pull request, data may have been lost. stdout: |
|
@antoine162 @xpl-odoo WARNING: the latest change (e923346) triggered a conflict when updating the next forward-port (#15062), and has been ignored. You will need to update this pull request differently, or fix the issue by hand on #15062. |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
e923346 to
416ba74
Compare
|
@antoine162 @xpl-odoo WARNING: the update of #15060 to 3090726 has caused a conflict in this pull request, data may have been lost. stdout: |
|
@antoine162 @xpl-odoo WARNING: the latest change (416ba74) triggered a conflict when updating the next forward-port (#15062), and has been ignored. You will need to update this pull request differently, or fix the issue by hand on #15062. |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
416ba74 to
2ba7f80
Compare
|
@antoine162 @xpl-odoo WARNING: the update of #15060 to 08a5668 has caused a conflict in this pull request, data may have been lost. stdout: |
|
@antoine162 @xpl-odoo WARNING: the latest change (2ba7f80) triggered a conflict when updating the next forward-port (#15062), and has been ignored. You will need to update this pull request differently, or fix the issue by hand on #15062. |
|
@antoine162 @xpl-odoo this forward port of #14908 is awaiting action (not merged or closed). |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
2ba7f80 to
9704d77
Compare
|
@antoine162 @xpl-odoo WARNING: the update of #15060 to c5f894c has caused a conflict in this pull request, data may have been lost. stdout: |
|
@antoine162 @xpl-odoo WARNING: the latest change (9704d77) triggered a conflict when updating the next forward-port (#15062), and has been ignored. You will need to update this pull request differently, or fix the issue by hand on #15062. |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
9704d77 to
9f1203a
Compare
|
@antoine162 @xpl-odoo WARNING: the update of #15060 to 59fd6f3 has caused a conflict in this pull request, data may have been lost. stdout: |
|
@antoine162 @xpl-odoo WARNING: the latest change (9f1203a) triggered a conflict when updating the next forward-port (#15062), and has been ignored. You will need to update this pull request differently, or fix the issue by hand on #15062. |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
9f1203a to
a6a3f9c
Compare
|
@antoine162 @xpl-odoo WARNING: the update of #15060 to 734093b has caused a conflict in this pull request, data may have been lost. stdout: |
|
@antoine162 @xpl-odoo WARNING: the latest change (a6a3f9c) triggered a conflict when updating the next forward-port (#15062), and has been ignored. You will need to update this pull request differently, or fix the issue by hand on #15062. |
fw-bot
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
a6a3f9c to
dd7a0ba
Compare
|
@antoine162 @xpl-odoo WARNING: the update of #15060 to 2327eea has caused a conflict in this pull request, data may have been lost. stdout: |
|
@antoine162 @xpl-odoo WARNING: the latest change (dd7a0ba) triggered a conflict when updating the next forward-port (#15062), and has been ignored. You will need to update this pull request differently, or fix the issue by hand on #15062. |
task-5094417 This commit rewrites the Taxes page. Previously, it came across as a huge list of tax configuration options. We now structure it as follows: 1. an overview of the tax flow in Odoo; 2. a set-up guide for taxes for new users; 3. an explanation of the most common configuration options. The options related to the tax computation are split into a separate Tax Computation page, in which we also improve the following sections: - Tax computations: At the moment, the section for the `Percentage of Price tax included` tax computation doesn't distinguish itself enough from the 'Included in Price' option which people usually want. We also improve the examples. - Included in Price - Affects base of subsequent taxes - Base affected by preceding taxes: this option was not documented, so we add a section for it. Ultimately, we plan to rewrite the Tax Computation page to provide a better explanation of how the tax computation actually works, and be more helpful at guiding the user to configure their taxes. X-original-commit: 64e8e5b
antoine162
force-pushed
the
saas-18.3-17.0-taxes-fix-computation-5094417-andu-474119-fw
branch
from
dd7a0ba to
e111262
Compare
|
Hiii @dade-odoo I did a small conflict fix here to incorporate your content on the tax mapping 😄 |
|
@antoine162 @xpl-odoo this forward port of #14908 is awaiting action (not merged or closed). |
dade-odoo
left a comment
dade-odoo
left a comment
There was a problem hiding this comment.
Hey @antoine162 , thanks for your work on this. I've made a few suggestions/corrections that all have to do with my version of the tax mapping section 😅 I'll be off Friday again, but back full time next week, so we can take a look together then or feel free to reach out on discord and I'll get back to you as soon as I can :)
| all fiscal positions or select specific fiscal positions where this tax should be used. If one or | ||
| multiple fiscal positions are selected, use the :guilabel:`Replaces` field to select all of the |
There was a problem hiding this comment.
| all fiscal positions or select specific fiscal positions where this tax should be used. If one or | |
| multiple fiscal positions are selected, use the :guilabel:`Replaces` field to select all of the | |
| all fiscal positions or select specific fiscal positions where this tax should be used. If one or | |
| more fiscal positions are selected, use the :guilabel:`Replaces` field to select all of the |
|
|
||
| .. image:: taxes/subsequent-line.png | ||
| :alt: The eco-tax is taken into the basis of the 21% VAT tax | ||
| .. image:: taxes/tax-mapping-example.png |
There was a problem hiding this comment.
Move this image to the example block instead of the note block
| When configuring a tax, leave the :guilabel:`Fiscal Position` field blank to apply the tax across | ||
| all fiscal positions or select specific fiscal positions where this tax should be used. If one or |
There was a problem hiding this comment.
Is it accurate to say that leaving it blank "applies" the tax across all fiscal positions? or should we say that leaving it blank "makes the tax available" across all fiscal positions? From what I can tell, all taxes (depending on sales/purchase type) are always available, but if it doesn't belong to the selected fiscal position (and also isn't left blank, which would indicate all fiscal positions), then it isn't immediately available in the M2M dropdown when selecting the tax, but you can still find it by clicking "Search more...". Does that sound like an accurate description? If so, I propose:
When configuring a tax, leave the :guilabel:
Fiscal Positionfield blank to make the tax
immediately available across all fiscal positions or select specific fiscal positions where this tax
should be used to replace other taxes with it.
4 participants
task-5094417
We improve the following sections of the Taxes page:
Tax computations:
At the moment, the section for the
Percentage of Price tax includedtax computation doesn't distinguish itself enough from the 'Included in Price' option which people usually want. We also improve the examples.Included in Price
Affects base of subsequent taxes
Base affected by preceding taxes: this option was not documented, so we add a section for it.
Forward-Port-Of: #14908