[FIX] html_builder: double-click to replace video

addons/html_builder/static/src/core/media_website_plugin.js

@@ -15,8 +15,8 @@ export class MediaWebsitePlugin extends Plugin {
             .map((s) => `${s}:not([data-oe-xpath])`)
             .join(",");
         this.addDomListener(this.editable, "dblclick", (ev) => {
-            const targetEl = ev.target;
-            if (!targetEl.matches(mediaSelector)) {
+            const targetEl = ev.target.closest(mediaSelector);
+            if (!targetEl) {
                 return;
             }
             let isEditable =

addons/html_builder/static/tests/videos.test.js

@@ -0,0 +1,21 @@
+import { expect, test } from "@odoo/hoot";
+import { animationFrame, dblclick } from "@odoo/hoot-dom";
+import { defineWebsiteModels, setupWebsiteBuilder } from "./website_helpers";
+
+defineWebsiteModels();
+
+test("double click on video", async () => {
+    await setupWebsiteBuilder(`
+        <div>
+            <div class="media_iframe_video o_snippet_drop_in_only">
+                <div class="css_editable_mode_display"></div>
+                <div class="media_iframe_video_size"></div>
+                <iframe frameborder="0" allowfullscreen="allowfullscreen" aria-label="Video"></iframe>
+            </div>
+        </div>
+    `);
+    expect(".modal-content").toHaveCount(0);
+    await dblclick(":iframe iframe");
+    await animationFrame();
+    expect(".modal-content:contains(Select a media) .o_video_dialog_form").toHaveCount(1);
+});

addons/html_editor/static/src/main/media/media_dialog/video_selector.js

@@ -37,7 +37,7 @@ export class VideoSelector extends Component {
         errorMessages: Function,
         vimeoPreviewIds: { type: Array, optional: true },
         isForBgVideo: { type: Boolean, optional: true },
-        media: { type: Object, optional: true },
+        media: { validate: (p) => p.nodeType === Node.ELEMENT_NODE, optional: true },
         "*": true,
     };
     static defaultProps = {