Skip to content

[FIX] html_builder: double-click to replace video #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

AlessandroLupo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented May 7, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@AlessandroLupo AlessandroLupo force-pushed the master-mysterious-egg-2-alup branch from 0aeaf4e to 659a26d Compare May 8, 2025 08:37
@AlessandroLupo
Copy link
Author

FGE asked me to add a test for the double click. The props validation for VideoSelector was failing in the test environment because of the object media not being recognized as instanceof Object(), so I slightly changed the props definition.

@AlessandroLupo AlessandroLupo requested a review from robinlej May 8, 2025 08:42
@AlessandroLupo AlessandroLupo force-pushed the master-mysterious-egg-2-alup branch from 659a26d to a4cd059 Compare May 8, 2025 08:43
@robinlej robinlej merged commit 8f6a7a2 into master-mysterious-egg May 8, 2025
@robinlej robinlej deleted the master-mysterious-egg-2-alup branch May 8, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants