Handle object expression inside a let in outline

[Tim-ats-d]

ocaml-lsp outline reports imbricated object inside let expression but merlin not. This fix aims to use merlin to generate outlines in ocaml-lsp without introduce regression in ocaml-lsp

The fix is ugly but I can refactor if needed.

cc @voodoos @xvw

[xvw]

For me, the fix is not ugly! Good job!

[voodoos]

Thanks a lot @Tim-ats-d !

I suspected that you could have a simpler implementation by relying more on the flat structure of the browse tree but I had to play with the code to find it, so i decided to directly push the change to your branch 🙈. Please have a look, it does remove quite a lot of the ad-hoc treatments:

0db503f

Apart from that, could you make the changelog entry more complete ? There is a "major' change in behavior here since before that patch Merlin outline's did not account for locally defined value, unlike ocaml-lsp. It seems reasonable to have them, but this should be made clear to users.

[Tim-ats-d]

Please have a look, it does remove quite a lot of the ad-hoc treatments
Nice, I understand Mbrowse better now. Thank you for the help!

I have also edited the change entry.