Draft: Delegate outline generation to Merlin #1529
Open
+46
−420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of the in-house solution for generating outlines by Merlin.
I had to regenerate the tests because merlin and ocaml-lsp don't calculate the positions of elements in the outline in the same way. Fir instance, the
y
loc was the enclosing location for ocaml-lsp:While Merlin indicates the exact position:
The PR diff also indicates that several items
kind
value have changed from 7 to 13. Indeed, Merlin treats instance variables asValues
and not asProperty
like ocaml-lsp does. This change simply means that the icon displayed on the vscode side will be differentCould you please mark this PR has draft? We have to wait for the next Merlin next because we need this patch ocaml/merlin#1936