Skip to content

Add <img> vs <picture> bookmark #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwthomas merged 1 commit into from
Jul 29, 2026
Merged

Add <img> vs <picture> bookmark #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/bookmarks/bookmarks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ export type Bookmark = {
export type Bookmarks = Array<Bookmark>;

export const BOOKMARKS: Bookmarks = [
{
id: "bbf0570e-8bb5-4f2c-8a7e-c17be854d15e",
date: "2026-07-29",
title: "<img> vs <picture>",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Escape bookmark titles in the Atom feed

When an Atom client requests /bookmarks/atom, app/bookmarks/atom/route.ts interpolates this title directly into XML, producing <title><img> vs <picture></title>. The unclosed elements make the entire feed malformed (an XML parser reports a mismatched tag), so feed readers cannot consume any entries; escape XML metacharacters while serializing bookmark titles.

Useful? React with 👍 / 👎.

url: "https://medium.com/@truszko1/picture-tags-vs-img-tags-their-uses-and-misuses-4b4a7881a8e1",
},
{
id: "717d0f8b-3e83-4e69-92ee-2bb1525d8060",
date: "2026-07-28",
Expand Down
Loading