Skip to content

Add <img> vs <picture> bookmark - #96

Merged
nwthomas merged 1 commit into
mainfrom
nwthomas/add-bookmark-for-img-vs-picture
Jul 29, 2026
Merged

Add <img> vs <picture> bookmark#96
nwthomas merged 1 commit into
mainfrom
nwthomas/add-bookmark-for-img-vs-picture

Conversation

@nwthomas

Copy link
Copy Markdown
Owner

Motivation

  • Add the requested Medium article to the site's bookmarks collection so it appears on the bookmarks page.

Description

  • Inserted a new bookmark object in app/bookmarks/bookmarks.ts with id: "bbf0570e-8bb5-4f2c-8a7e-c17be854d15e", date: "2026-07-29", title: "<img> vs <picture>", and the provided Medium url.
  • Committed the change to the repository (push was not performed because no remote is configured in this environment).

Testing

  • Ran bunx prettier --check app/bookmarks/bookmarks.ts, which passed.
  • Ran make lint (ESLint), which produced no errors.
  • Attempted make build; initial runs failed due to missing font files and required environment variables (REDIS_URL / REDIS_TOKEN), so a full production build could not be validated in this environment.

Codex Task

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
personal-portfolio Ready Ready Preview Jul 29, 2026 8:02pm

@nwthomas
nwthomas merged commit c0e5a4d into main Jul 29, 2026
2 of 3 checks passed
@nwthomas
nwthomas deleted the nwthomas/add-bookmark-for-img-vs-picture branch July 29, 2026 20:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c5daf2949

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{
id: "bbf0570e-8bb5-4f2c-8a7e-c17be854d15e",
date: "2026-07-29",
title: "<img> vs <picture>",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Escape bookmark titles in the Atom feed

When an Atom client requests /bookmarks/atom, app/bookmarks/atom/route.ts interpolates this title directly into XML, producing <title><img> vs <picture></title>. The unclosed elements make the entire feed malformed (an XML parser reports a mismatched tag), so feed readers cannot consume any entries; escape XML metacharacters while serializing bookmark titles.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant