Add <img> vs <picture> bookmark - #96
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c5daf2949
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| id: "bbf0570e-8bb5-4f2c-8a7e-c17be854d15e", | ||
| date: "2026-07-29", | ||
| title: "<img> vs <picture>", |
There was a problem hiding this comment.
Escape bookmark titles in the Atom feed
When an Atom client requests /bookmarks/atom, app/bookmarks/atom/route.ts interpolates this title directly into XML, producing <title><img> vs <picture></title>. The unclosed elements make the entire feed malformed (an XML parser reports a mismatched tag), so feed readers cannot consume any entries; escape XML metacharacters while serializing bookmark titles.
Useful? React with 👍 / 👎.
Motivation
Description
app/bookmarks/bookmarks.tswithid: "bbf0570e-8bb5-4f2c-8a7e-c17be854d15e",date: "2026-07-29",title: "<img> vs <picture>", and the provided Mediumurl.Testing
bunx prettier --check app/bookmarks/bookmarks.ts, which passed.make lint(ESLint), which produced no errors.make build; initial runs failed due to missing font files and required environment variables (REDIS_URL/REDIS_TOKEN), so a full production build could not be validated in this environment.Codex Task