-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEBUI-1616: rtl support (Hebrew and Arabic) #2409
Open
rakeshkumar1019
wants to merge
37
commits into
maintenance-3.1.x
Choose a base branch
from
task-WEBUI-1616-rtl-support
base: maintenance-3.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+375
−13
Open
Changes from 24 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
588dacc
WEBUI-1616: rtl phase1
rakeshkumar1019 add552e
WEBUI-1616: rtl phase2
rakeshkumar1019 193bbd5
WEBUI-1616: remove rtl-setup code from index.jsp
rakeshkumar1019 d12f650
ELEMENTS-1779: provide RTL Support for WebUI (Hebrew and Arabic) - Pa…
rakeshkumar1019 5ca503c
WEBUI-1616: removed rtl-setup.js file from index.html
rakeshkumar1019 15e478d
WEBUI-1616: revert right-drawer$=[[_isRTL]] from index.html
rakeshkumar1019 dfb343f
WEBUI-1616: left: 0 on nuxeo-app
rakeshkumar1019 7faf088
WEBUI-1616: revert left: 0 on nuxeo-app
rakeshkumar1019 1cf0053
WEBUI-1616: chnages in nuxeo-app
rakeshkumar1019 09506b2
WEBUI-1616: chnages in nuxeo-app
rakeshkumar1019 d2dcf8d
WEBUI-1616: chnages in nuxeo-app
rakeshkumar1019 53659e3
WEBUI-1616: revert index.js
rakeshkumar1019 6374c33
WEBUI-1616: revert nuxeo-app & nuxeo-page
rakeshkumar1019 e394ff5
WEBUI-1616: revert nuxeo-app & nuxeo-page
rakeshkumar1019 559f0c7
WEBUI-1616: revert nuxeo-app & nuxeo-page
rakeshkumar1019 3b045d6
inline js
rakeshkumar1019 bdbea78
build
rakeshkumar1019 cfff511
build
rakeshkumar1019 678ed09
WEBUI-1616: revert a11y action
rakeshkumar1019 69ae125
WEBUI-1616: final code
rakeshkumar1019 9b9c8b7
WEBUI-1616: final code
rakeshkumar1019 5f8e9a0
WEBUI-1616: admin.js ftest
rakeshkumar1019 6b864fe
WEBUI-1616: nuxeo-menu-icon tooltip
rakeshkumar1019 20e1bde
WEBUI-1616: ftest browser & search
rakeshkumar1019 f0de379
WEBUI-1616: responsive rtl
rakeshkumar1019 b8ab5e8
WEBUI-1616: review comments
rakeshkumar1019 1dee7c7
WEBUI-1616: text number combination handle for rtl
rakeshkumar1019 b83834c
WEBUI-1616: toast messages for rtl
rakeshkumar1019 86a9f3b
WEBUI-1616: note editor, suggester & page items
rakeshkumar1019 9a12240
WEBUI-1616: nuxeo document tree
rakeshkumar1019 5d2e7d1
Merge branch 'maintenance-3.1.x' into task-WEBUI-1616-rtl-support
rakeshkumar1019 a1b256b
WEBUI-1616: nuxeo picture formats
rakeshkumar1019 038f279
WEBUI-1616: build artifact
rakeshkumar1019 df3a2f0
WEBUI-1616: revert nuxeo document tree
rakeshkumar1019 4643aad
WEBUI-1616: nuxeo document tree
rakeshkumar1019 3e425a9
WEBUI-1616: nuxeo-note-editor
rakeshkumar1019 63a78dc
webui-1616: document page & suggester
rakeshkumar1019 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,12 @@ Polymer({ | |
nuxeo-document-create-shortcuts { | ||
--nuxeo-document-create-shortcut-margin: 0 0 16px 0; | ||
} | ||
|
||
:host([dir='rtl']) #tray { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. place it below the #tray css for better visibility |
||
left: 32px; | ||
right: auto; | ||
overflow: hidden; | ||
} | ||
</style> | ||
|
||
<nuxeo-document id="defaultDoc" doc-path="[[parent.path]]" enrichers="permissions, subtypes" response="{{parent}}"> | ||
|
@@ -128,6 +134,13 @@ Polymer({ | |
'create-document': '_hideShortcuts', | ||
}, | ||
|
||
ready() { | ||
if (!this.hasAttribute('dir')) { | ||
const direction = document.documentElement.getAttribute('dir'); | ||
this.setAttribute('dir', direction); | ||
} | ||
}, | ||
|
||
_parentChanged() { | ||
if (this.parent) { | ||
if ( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate property. already mentioned in 153