WEBUI-1616: rtl support (Hebrew and Arabic) #2409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshkumar1019
requested review from
suneet-gupta and
aradhanas9
and removed request for
a team
rakeshkumar1019
force-pushed
the
task-WEBUI-1616-rtl-support
branch
from
ca9da5d to
9b9c8b7
Compare
rakeshkumar1019
requested review from
madhurkulshrestha-hyland
and removed request for
suneet-gupta and
aradhanas9
rakeshkumar1019
changed the title
swarnadipa-dev
approved these changes
Jan 7, 2025
alokhyland
approved these changes
Jan 7, 2025
madhurkulshrestha-hyland
requested changes
Jan 7, 2025
| #logo img { | ||
| width: var(--nuxeo-sidebar-width); | ||
| height: 53px; | ||
| } | ||
| :host([dir='rtl']) #logo { |
There was a problem hiding this comment.
duplicate property. already mentioned in 153
| @@ -70,6 +70,12 @@ Polymer({ | |||
| nuxeo-document-create-shortcuts { | |||
| --nuxeo-document-create-shortcut-margin: 0 0 16px 0; | |||
| } | |||
| :host([dir='rtl']) #tray { | |||
There was a problem hiding this comment.
place it below the #tray css for better visibility
| @@ -82,6 +82,22 @@ | |||
| </div> | |||
| </nuxeo-app> | |||
|
|
|||
| <script> | |||
There was a problem hiding this comment.
shouldnt this be picked from index.js ??
| @@ -140,6 +140,22 @@ limitations under the License. | |||
| </div> | |||
| </nuxeo-app> | |||
| <script nonce="<%= NX_NONCE_VALUE %>"> | |||
| window.nuxeo = window.nuxeo || {}; | |||
There was a problem hiding this comment.
shouldnt this be picked up from index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.