Skip to content

Api fixes#220

Open
fjarri wants to merge 9 commits intonucypher:mainfrom
fjarri:api-fixes
Open

Api fixes#220
fjarri wants to merge 9 commits intonucypher:mainfrom
fjarri:api-fixes

Conversation

@fjarri
Copy link

@fjarri fjarri commented Nov 6, 2025

Based on top of #218

Type of PR:

  • Refactor

Required reviews:

How many reviews does the PR author need?

  • 2

What this does:

  • Removes Ethereum addresses from the API completely since they play no role in the cryptographic operations, and are not even serialized (Validator structures are transient; the Rust Validator impls Serialize, but the serialization is not exposed in the bindings). If the user wants to associate addresses with validators, they can do it in their own code.
  • Removes me from Dkg. None of its methods beside create_share ones require me, and the share creation ones already get the validator keypair, so we can locate the share index by the public key. (seems like it makes ferveo-python/examples/exception.py meaningless?)
  • Removes the public_key field from AggregatedTranscript (use public_key() method instead). Fixes api::AggregatedTranscript serialization issue in nucypher/nucypher #209

@fjarri fjarri force-pushed the api-fixes branch 3 times, most recently from 1f7feb6 to 035e536 Compare November 6, 2025 23:40
@fjarri
Copy link
Author

fjarri commented Nov 7, 2025

I can include a fix for #209 here too.

@fjarri fjarri force-pushed the api-fixes branch 5 times, most recently from 6f19f9b to 223c020 Compare November 8, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api::AggregatedTranscript serialization issue in nucypher/nucypher

1 participant