Allow opt-in task toggles in read-only editors - #178
Open
yvos wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in wrapper policy that keeps task checkboxes interactive while NSTextView remains non-editable. Qualification proved the existing isEditable=false path rejects shouldChangeText, which justifies a narrow opt-in API; the default stays fully read-only. Tests exercise the actual checkbox hit-test and click mutation path, prove ordinary edits remain rejected, cover second-of-two exact-range changes under LF and CRLF, verify the exact three-character onTextMutation callback, preserve the settled binding, and prove document-scoped undo and redo. Includes 6 focused tests; the full suite passes 476 tests in 69 suites. Follow-up embedder parity work discovered while implementing issue #173.