fix(action): correct lint path, clean up warnings, fix lints

[bmuenzenmeyer]

Description

https://github.com/nodejs/nodejs.org/actions/runs/10850360175/job/30111620392 failed due to incorrect eslint configuration/invocation

Validation

npx eslint "apps/site/pages/**/*.md?(x)" --fix --cache --cache-strategy=metadata --cache-file=apps/site/.eslintmdcache --config=apps/site/eslint.config.js

⬆️ succeeds now

A cleaned up and rebased #7040 should succeed

Related Issues

supports #7040 cleanly

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run npm run format to ensure the code follows the style guide.
• I have run npm run test to check if all tests are passing.
• I have run npx turbo build to check if the website builds without errors.
• I've covered new added functionality with unit tests if necessary.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Sep 13, 2024 9:59pm

[bmuenzenmeyer]

with only 97eeda0, we get

Pages directory cannot be found at C:\src\nodejsorg\pages or C:\src\nodejsorg\src\pages. If using a custom path, please configure with the `no-html-link-for-pages` rule in your eslint config file.

414f133 addresses this

[bmuenzenmeyer]

we also get

(node:3164) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
(Use `node --trace-warnings ...` to show where the warning was created)

cb1a961 addresses this

[github-actions]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.47% (589/651)	76.29% (177/232)	94.35% (117/124)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
131	0 💤	0 ❌	0 🔥	5.185s ⏱️