Skip to content

Commit

Permalink
fix(action): correct lint path, clean up warnings, fix lints (#7043)
Browse files Browse the repository at this point in the history
* fix(action): supply config path

* fix(eslint): supply custom path to pages

* fix(eslint): replace deprecated ignore approach
  • Loading branch information
bmuenzenmeyer committed Sep 16, 2024
1 parent 4139bbb commit d9e0865
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
5 changes: 0 additions & 5 deletions .eslintignore

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/translations-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
- name: Run `npx lint:md --fix`
# This runs a specific version of ESLint with only the Translation Pages Globbing
# This avoid that unrelated changes get linted/modified within this PR
run: npx eslint "apps/site/pages/**/*.md?(x)" --fix --cache --cache-strategy=metadata --cache-file=apps/site/.eslintmdcache
run: npx eslint "apps/site/pages/**/*.md?(x)" --fix --cache --cache-strategy=metadata --cache-file=apps/site/.eslintmdcache --config=apps/site/eslint.config.js

- name: Run `npx prettier --write`
# This runs a specific version of Prettier with only the Translation Pages Globbing
Expand Down
2 changes: 2 additions & 0 deletions apps/site/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const compatConfig = compat.config({
export default tseslint.config(
{
ignores: [
'node_modules',
'.next',
'.swc',
'.turbo',
Expand Down Expand Up @@ -88,6 +89,7 @@ export default tseslint.config(
rules: {
'no-irregular-whitespace': 'off',
'@next/next/no-img-element': 'off',
'@next/next/no-html-link-for-pages': ['error', 'apps/site/pages/'],

// https://github.com/typescript-eslint/typescript-eslint/issues/9860
'@typescript-eslint/consistent-type-imports': 'off',
Expand Down
2 changes: 2 additions & 0 deletions packages/i18n/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import tseslint from 'typescript-eslint';
export default tseslint.config(
{
ignores: [
'node_modules',
'.turbo',
'build',
'coverage',
'global.d.ts',
Expand Down

0 comments on commit d9e0865

Please sign in to comment.