GitHub Action to run tests on most versions of Node.js #957
Conversation
cclauss
force-pushed
the
patch-1
branch
2 times, most recently
from
45275bc to
a4c43c0
Compare
|
The tests pass so let’s merge without Node.js v23 until |
|
@kkoopa Your review, please. It is surprising to find a https://github.com/nodejs repo with no automated testing. |
|
Sorry for the delay. I will look closer later, but for now it seems like there are only a couple versions tested here. Can this be extended to incorporate all the old, ugly releases? We actually do have CI testing, but most of it has broken or been discontinued over the years. AppVeyor still works however and it tests some 22 versions across multiple platforms. |
|
I cannot find the AppVeyor test results. Can we see a nan-related URL like https://ci.appveyor.com/project/cclauss/appveyor-hack ? |
|
Ah yes, it is one of the badges in the main readme. The Travis one does not work anymore, but here is the AppVeyor link. The failures on 23 are known. https://ci.appveyor.com/project/RodVagg/nan
…On February 5, 2025 9:10:17 PM GMT+02:00, Christian Clauss ***@***.***> wrote:
I cannot find the AppVeyor test results.
Can you see a URL like https://ci.appveyor.com/project/cclauss/appveyor-hack ?
--
Reply to this email directly or view it on GitHub:
#957 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
|
@kkoopa asked:
I would very much appreciate a review of this and my other PRs so that we have updated AppVeyor and GitHub Actions testing in place before we merge solutions to key customer issues: |
cclauss
changed the title
|
@tniessen Your review, please. |
cclauss
changed the title
Test results: https://github.com/cclauss/nan/actions
@rvagg Your review, please.