TODO: Enable macOS after #985 or similar

nodejs · Feb 9, 2025 · 473029c · 473029c
1 parent d41536f
commit 473029c
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,4 +1,5 @@
 # https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs
+# https://github.com/actions/setup-node
 # https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
 
 name: ci
@@ -18,13 +19,14 @@ jobs:
         node-version: [22.x, 21.x, 20.x, 19.x, 18.x, 17.x, 16.x, 15.x]
         os: [windows-latest]
         include:
-          - node-version: 22.x
-            os: macos-13  # macOS on Intel
-          - node-version: 22.x
-            os: macos-latest  # macOS on arm64
-          - node-version: 22.x
+          # TODO: Enable macOS after nodejs/nan#985 or similar.
+          # - node-version: lts/*
+          #  os: macos-13  # macOS on Intel
+          # - node-version: lts/*
+          #  os: macos-latest  # macOS on arm64
+          - node-version: lts/*
             os: ubuntu-latest  # Linux on x64
-          - node-version: 22.x
+          - node-version: lts/*
             os: ubuntu-24.04-arm  # Linux on arm64
           - node-version: 14.x
             os: windows-2019
@@ -46,7 +48,7 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - run: npm install
       # TODO: On Windows Node.js v11 these will fail but `make test` will succeed
-      - if: matrix.node-version == '11.x'
+      - if: matrix.node-version != '11.x'
         run: |
           npm run-script rebuild-tests
           npm test