Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hard coding of meeting group. #4

Merged
merged 2 commits into from
Nov 17, 2017
Merged

remove hard coding of meeting group. #4

merged 2 commits into from
Nov 17, 2017

Conversation

priyank-p
Copy link
Contributor

`npm run tsc-meeting` would create tsc meeting,
`npm run benchmarking-meeting` would create benchmarking meeting
mhdawson

This comment was marked as off-topic.

@mhdawson
Copy link
Member

@cPhost thanks. Will test out and then land as I make the next TSC meeting

@priyank-p
Copy link
Contributor Author

@mhdawson ping me again if you need my help again in this or other repo.

@mhdawson
Copy link
Member

@cPhost the next thing that would be great to get done is https://github.com/mhdawson/create-node-meeting-artifacts/issues/3

@mhdawson mhdawson merged commit 1bf6e9f into nodejs:master Nov 17, 2017
@mhdawson
Copy link
Member

@cPhost one other thing I noticed is that the additional entries in the package.json (which is a great idea) don't seem to work when I try to run them with npm X with X being one of the new names in the script entries.

@priyank-p
Copy link
Contributor Author

priyank-p commented Nov 17, 2017

I will take a look at that situation.

edit: @mhdawson did you use npm run X if not that why its not working.
Event better if you want i can make it so you can run
create-meeting-tsc or create-meeting-benchmarking or anything you want?

@mhdawson
Copy link
Member

@cPhost thanks, I was not using the 'run' option, will try that out. If we can make it so that we don't have to add a new entry for each meeting we start supporting that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants