Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: remove hard coding of TSC #2

Closed
mhdawson opened this issue Nov 2, 2017 · 3 comments
Closed

TODO: remove hard coding of TSC #2

mhdawson opened this issue Nov 2, 2017 · 3 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Nov 2, 2017

Use parameter as opposed to hard coding TSC.
@priyank-p
Copy link
Contributor

@mhdawson sorry for delay i was busy with node-core-utils. I need some guidance for this,
By removing to you mean get it from readme.md if not can you please let me know where to get it from.

@mhdawson
Copy link
Member Author

What I meant was instead of hard coding it in this line:

const meetingGroup = 'TSC';

to pull it from the arguments. Its a pretty small change. I may look at this tomorrow as I want to use the tool create the meeting artifacts for the Benchmarking meeting next Monday. If you have a chance before then a PR would be welcome.

@priyank-p priyank-p mentioned this issue Nov 17, 2017
Merged
@mhdawson
Copy link
Member Author

Closed by https://github.com/mhdawson/create-node-meeting-artifacts/pull/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhdawson @priyank-p