-
Notifications
You must be signed in to change notification settings - Fork 14
Patch Rake::Task#execute instead of Rake::Application#display_error_message #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Patch Rake::Task#execute instead of Rake::Application#display_error_message #27
Conversation
Someone should just fork Airbrake and replace Airbrake-specific things with |
Manually tested using https://github.com/TylerRick/exception_notification-rake_example_with_spring/tree/workaround_using_execute_patch Would be nice to have integration tests like Airbrake has. I really wonder if forking Airbrake would be the most efficient route. |
Another unexpected benefit of this PR is that it appears to use my local time zone now. (I'm not sure why this changed ... maybe ExceptionNotifier uses the Before: |
Thanks @TylerRick - this is quite a fundamental change. Agreed that having integration tests would be really useful for this kind of thing. Do you have any ideas how to achieve that? Can you also rebase this on top of master so we get a clearer diff (your other PRs are merged)? |
1a4d16b
to
5047c80
Compare
All right, it's rebased :) It's basically just copying how they do it in https://github.com/airbrake/airbrake/blob/master/lib/airbrake/rake.rb, since they no longer do it the way they used to (the way that originally inspired this gem, I believe)... |
…essage This is based on how https://github.com/airbrake/airbrake/blob/master/lib/airbrake/rake.rb does it Fixes nikhaldi#26
5047c80
to
1a72694
Compare
All right, it's rebased again! |
FYI: This PR (and this gem in general) may be redundant now that smartinez87/exception_notification#536 has been merged |
This is based on how https://github.com/airbrake/airbrake/blob/master/lib/airbrake/rake.rb does it.
Fixes #26