Skip to content

Notify of errors in runner commands #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TylerRick
Copy link
Contributor

@TylerRick TylerRick commented Jun 20, 2023

Resolves #33

Depends on / based on #27, which aligns things more with the nice, organized way that Airbrake does things in their railtie.

I would have liked to include the full runner command string in the data hash so it's visible in the exception notification. Unfortunately, it appears that ARGV is not available from runner hook, so we can't reconstruct the full runner command string like we did with reconstruct_command_line.

I've worked around this before, like this in the paper_trail-rails gem, but it wasn't as clean as I'd like (basically you have to put your override file at lib/rails/commands/runner/runner_command.rb to get it to be loaded instead of the version from railties).

@TylerRick
Copy link
Contributor Author

FYI: This PR (and this gem in general) may be redundant now that smartinez87/exception_notification#536 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rails: use runner API to handle exceptions in Rails runner
1 participant