Notify of errors in runner commands #34
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33
Depends on / based on #27, which aligns things more with the nice, organized way that Airbrake does things in their railtie.
I would have liked to include the full runner command string in the data hash so it's visible in the exception notification. Unfortunately, it appears that
ARGV
is not available fromrunner
hook, so we can't reconstruct the full runner command string like we did withreconstruct_command_line
.I've worked around this before, like this in the paper_trail-rails gem, but it wasn't as clean as I'd like (basically you have to put your override file at
lib/rails/commands/runner/runner_command.rb
to get it to be loaded instead of the version fromrailties
).