Skip to content

Commit

Permalink
adjust bindings-forwarder deployment template (#529)
Browse files Browse the repository at this point in the history
<!-- Thank you for contributing! Please make sure that your code changes
are covered with tests. In case of new features or big changes remember
to adjust the documentation.

In case of an existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

## What
When using extraVolumes and extraVolumeMounts the indentation was a little bit off which was causing the templating to generate invalid yaml.

## How
*Describe the solution*
change the indentation and add dashes so there's no blank lines.

Before:
```
        - name: SSL_CERT_DIR
          value:
            /etc/ssl/certs/ngrok
        volumeMounts:

          - mountPath: /etc/ssl/certs/ngrok
            name: ca-certs
            readOnly: true
        - name: ngrok-ca
          mountPath: /etc/ssl/certs/ngrok
          readOnly: true
```

## Breaking Changes
none
  • Loading branch information
hjkatz authored Nov 27, 2024
2 parents 6604eab + 7945565 commit c71e290
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ spec:
{{- end }}
{{- if .Values.extraVolumeMounts }}
volumeMounts:
{{ toYaml .Values.extraVolumeMounts | nindent 10 }}
{{- toYaml .Values.extraVolumeMounts | nindent 8 }}
- name: ngrok-ca
mountPath: /etc/ssl/certs/ngrok
readOnly: true
Expand All @@ -106,7 +106,7 @@ spec:
{{- end }}
{{- if .Values.lifecycle }}
lifecycle:
{{ toYaml .Values.lifecycle | nindent 10 }}
{{- toYaml .Values.lifecycle | nindent 10 }}
{{- end }}
livenessProbe:
httpGet:
Expand All @@ -124,7 +124,7 @@ spec:
{{- toYaml .Values.resources | nindent 10 }}
{{- if .Values.extraVolumes }}
volumes:
{{ toYaml .Values.extraVolumes | nindent 6 }}
{{- toYaml .Values.extraVolumes | nindent 8 }}
- name: ngrok-ca
configMap:
name: ngrok-intermediate-ca
Expand Down

0 comments on commit c71e290

Please sign in to comment.