Skip to content

Commit

Permalink
Merge pull request #526 from ngrok/hkatz/test-e2e
Browse files Browse the repository at this point in the history
e2e updates / fixes 1
  • Loading branch information
hjkatz authored Nov 27, 2024
2 parents b8be5f6 + d7a3995 commit 6604eab
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
14 changes: 0 additions & 14 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ on:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
pull_request_target:
branches: [ "main" ]

env:
GO_VERSION: '1.23'
Expand Down Expand Up @@ -89,18 +87,6 @@ jobs:
- run: git diff --exit-code go.mod
- run: git diff --exit-code go.sum

echo:
runs-on: ubuntu-latest
needs: [changes]
steps:
- uses: actions/checkout@v3
- run: |
echo "go: ${{ needs.changes.outputs.go }}"
echo "charts: ${{ needs.changes.outputs.charts }}"
echo "chartyaml: ${{ needs.changes.outputs.chartyaml }}"
echo "tests: ${{ needs.changes.outputs.tests }}"
echo "make: ${{ needs.changes.outputs.make }}"
build-and-test:
runs-on: ubuntu-latest
needs:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,10 @@ jobs:
- uses: "./.github/actions/changes"
id: changes

build-and-test:
build-and-test-e2e:
runs-on: ubuntu-latest
needs:
- changes
- kubebuilder-diff
if: |
(needs.changes.outputs.go == 'true') ||
(needs.changes.outputs.charts == 'true') ||
Expand Down

0 comments on commit 6604eab

Please sign in to comment.