Skip to content

Commit

Permalink
Merge pull request #528 from ngrok/hkatz/test-e2e-2
Browse files Browse the repository at this point in the history
Trigger ci e2e with Makefile change
  • Loading branch information
hjkatz authored Nov 27, 2024
2 parents c71e290 + 1710c8c commit 0fc24e4
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 11 deletions.
6 changes: 5 additions & 1 deletion .github/actions/build-and-test/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ runs:
run: |
kubectl get nodes
kubectl get pods -A
sleep 20
kubectl get pods -A
kubectl describe pod -l app.kubernetes.io/component=controller
kubectl logs -l app.kubernetes.io/component=controller --tail=-1
- name: Install cosign
if: ${{ inputs.run-e2e == 'true' }}
Expand All @@ -97,6 +101,6 @@ runs:
# that hopefully helps not pollute our ngrok-operator-ci account
- name: Cleanup e2e tests
shell: bash
if: ${{ inputs.run-e2e == 'true' }}
if: ${{ always() && inputs.run-e2e == 'true' }}
run: |
make e2e-clean
14 changes: 9 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,15 @@ jobs:
- changes
- kubebuilder-diff
if: |
(needs.changes.outputs.go == 'true') ||
(needs.changes.outputs.charts == 'true') ||
(needs.changes.outputs.chartyaml == 'true') ||
(needs.changes.outputs.tests == 'true') ||
(needs.changes.outputs.make == 'true')
(github.event.type == 'PushEvent' && github.ref_name == 'main')
||
(
(needs.changes.outputs.go == 'true') ||
(needs.changes.outputs.charts == 'true') ||
(needs.changes.outputs.chartyaml == 'true') ||
(needs.changes.outputs.tests == 'true') ||
(needs.changes.outputs.make == 'true')
)
permissions:
contents: read
pull-requests: read
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,15 @@ jobs:
needs:
- changes
if: |
(needs.changes.outputs.go == 'true') ||
(needs.changes.outputs.charts == 'true') ||
(needs.changes.outputs.chartyaml == 'true') ||
(needs.changes.outputs.tests == 'true') ||
(needs.changes.outputs.make == 'true')
(github.event.type == 'PushEvent' && github.ref_name == 'main')
||
(
(needs.changes.outputs.go == 'true') ||
(needs.changes.outputs.charts == 'true') ||
(needs.changes.outputs.chartyaml == 'true') ||
(needs.changes.outputs.tests == 'true') ||
(needs.changes.outputs.make == 'true')
)
permissions:
contents: read
pull-requests: read
Expand Down
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ IMG ?= ngrok-operator
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.29.0

# Repository URL
REPO_URL = github.com/ngrok/ngrok-operator

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
Expand Down

0 comments on commit 0fc24e4

Please sign in to comment.