Skip to content

Fix mention picker tab wrapping #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YUHAO-corn wants to merge 1 commit into from
+13 −5
Closed

Fix mention picker tab wrapping #3942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/web/src/styles/workspace/mention-home.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,18 @@
display: flex;
align-items: center;
align-content: flex-start;
flex-wrap: wrap;
flex-wrap: nowrap;
gap: 4px;
min-height: 0;
padding: 6px;
background: var(--bg-subtle);
border-bottom: 1px solid var(--border-soft);
overflow: hidden;
overflow-x: auto;
overflow-y: hidden;
scrollbar-width: none;
}
.mention-tabs::-webkit-scrollbar {
display: none;
}
.mention-tab {
flex: 0 0 auto;
Expand Down
9 changes: 6 additions & 3 deletions apps/web/tests/styles/mention-popover.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,16 @@ describe('mention popover styles', () => {
expect(ruleValue(results, 'overflow-y')).toBe('auto');
});

it('wraps category tabs inside the panel without clipping labels', () => {
it('keeps category tabs on one line without clipping labels', () => {
const tabs = cssBlock('.mention-tabs');
const tab = cssBlock('.mention-tab');

expect(ruleValue(tabs, 'flex-wrap')).toBe('wrap');
expect(ruleValue(tabs, 'overflow')).toBe('hidden');
expect(ruleValue(tabs, 'flex-wrap')).toBe('nowrap');
expect(ruleValue(tabs, 'overflow-x')).toBe('auto');
expect(ruleValue(tabs, 'overflow-y')).toBe('hidden');
expect(ruleValue(tabs, 'scrollbar-width')).toBe('none');
expect(ruleValue(tab, 'flex')).toBe('0 0 auto');
expect(ruleValue(tab, 'min-inline-size')).toBe('max-content');
expect(ruleValue(tab, 'white-space')).toBe('nowrap');
});

Expand Down
Loading