Skip to content

Fix mention picker tab wrapping#3942

Closed
YUHAO-corn wants to merge 1 commit into
nexu-io:mainfrom
YUHAO-corn:yuhao/fix-picker-tabs-wrap-3890
Closed

Fix mention picker tab wrapping#3942
YUHAO-corn wants to merge 1 commit into
nexu-io:mainfrom
YUHAO-corn:yuhao/fix-picker-tabs-wrap-3890

Conversation

@YUHAO-corn

@YUHAO-corn YUHAO-corn commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep mention picker category tabs on a single row
  • allow the tab rail to scroll horizontally instead of wrapping labels
  • update the mention popover style coverage for the new no-wrap contract

Fixes #3890.

Surface area

  • UI
  • Daemon/runtime
  • Docs
  • Tests only

Tests

  • node lightweight CSS assertion for mention tab rules
  • git diff --check

Note: the focused Vitest command could not run locally in this fresh worktree because node_modules is not installed; relying on CI for the full test run.

@lefarcen lefarcen requested a review from Siri-Ray June 8, 2026 18:56
@lefarcen lefarcen added size/XS PR changes <20 lines risk/medium Medium risk: regular code changes type/bugfix Bug fix labels Jun 8, 2026

@lefarcen lefarcen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @YUHAO-corn! The fix is well-scoped — nowrap + horizontal scroll is exactly the right contract to hold the tab rail stable regardless of how many file-backed tabs appear. The test coverage update mirrors the change cleanly.

One small template gap before this goes to pool review: could you add a ## Surface area section and tick UI (this change affects the mention picker tab rail visually)? The rest of the body reads clearly as-is.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Visual regression review

Head: a77fed4 · Base: 75f1472

3 changed · 14 unchanged · 0 missing baseline · 0 failed

Changed cases

Case Main PR Diff
visual-design-systems main pr diff
visual-home-plugin-filter main pr diff
visual-new-project-modal main pr diff
Unchanged cases
Case Main PR Diff
visual-avatar-menu main pr diff
visual-home main pr diff
visual-home-catalog main pr diff
visual-home-context-picker main pr diff
visual-integrations main pr diff
visual-integrations-use-everywhere main pr diff
visual-plugin-details main pr diff
visual-plugins main pr diff
visual-projects main pr diff
visual-projects-kanban main pr diff
visual-settings-byok main pr diff
visual-settings-execution main pr diff
visual-tasks main pr diff
visual-topbar-execution-switcher main pr diff

Visual diff is advisory only and does not block merging.

@lefarcen

lefarcen commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

All gates green — @Siri-Ray approved, CI is passing. Flagged for the maintainers to merge. Thanks for the clean fix @YUHAO-corn! 🎉

@kokisanai

Copy link
Copy Markdown
Contributor

Hi @YUHAO-corn!

This PR looks quiet for a bit, so I'm checking in to make sure it doesn't get stuck.

If you are waiting on review, feedback, or a specific unblock from the team, feel free to say so here. If faster coordination helps, you can also drop into our contributors channel in Discord:
https://discord.gg/3C6EWXbdQQ

We want to help move this forward instead of letting it stall.

@lefarcen lefarcen added needs-validation Runtime change detected; needs human or /explore agent validation. and removed needs-validation Runtime change detected; needs human or /explore agent validation. labels Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@YUHAO-corn friendly reminder: this PR has been waiting on an author response for more than 3 days after reviewer or maintainer feedback.

When you have a chance, please reply here or push an update. To keep the queue manageable, PRs with no author activity for more than 5 days after feedback may be closed automatically, but they can be reopened when work resumes.

@lefarcen

Copy link
Copy Markdown
Contributor

🧪 This PR has changes that need manual QA validation, so it needs a QA pass by @AmyShang-alt before merge — please hold off self-merging; we'll loop QA in once it's merge-ready.

@lefarcen lefarcen added the needs-validation Runtime change detected; needs human or /explore agent validation. label Jun 12, 2026
@lefarcen

Copy link
Copy Markdown
Contributor

Hey @YUHAO-corn — thanks for the focused fix. Since this PR changes visible mention picker UI behavior, could you please add screenshots to the PR body?

The key change is that the mention picker category tabs should stay on a single row and scroll horizontally instead of wrapping onto multiple lines. Without screenshots, it is hard to verify the real UI layout, especially when many file-backed tabs are present.

A small before/after capture would be ideal:

  • Before: mention picker tabs wrapping onto two lines
  • After: tabs staying on one row with horizontal overflow behavior

This will make the UI review much easier. Thanks! 🙌

@github-actions

Copy link
Copy Markdown
Contributor

Closing this PR for now because it has been waiting on an author response for more than 5 days after reviewer or maintainer feedback.

This is only a queue-management step, not a rejection of the work. If you would like to continue, please leave a comment or push an update and reopen the PR when ready.

@github-actions github-actions Bot closed this Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-validation Runtime change detected; needs human or /explore agent validation. risk/medium Medium risk: regular code changes size/XS PR changes <20 lines type/bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uploading a file can make picker tabs wrap onto two lines

3 participants