-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update attributes as per semantic convention and add more conditions #1906
base: main
Are you sure you want to change the base?
Changes from all commits
91a69df
c0a0e4f
ca29b24
2423b3f
233e9a5
bce08df
d2dd934
122b600
f3ab1ef
9f6acf4
ac8ccb7
1002c5a
0a78548
a128745
b6cc28d
592d791
ee47b4b
e2307e3
5d979bb
496939f
07515e1
c4589c5
bed8f1a
b6ef51f
ad85d46
7f32fef
830c5c2
085d332
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,13 +3,18 @@ relationships: | |
version: "1" | ||
origins: | ||
- Distributed Tracing | ||
- OpenTelemetry | ||
conditions: | ||
- attribute: eventType | ||
anyOf: [ "Span" ] | ||
- attribute: instrumentation.provider | ||
anyOf: [ "opentelemetry" ] | ||
- attribute: newrelic.source | ||
anyOf: [ "api.traces.otlp" ] | ||
- attribute: entity.type | ||
anyOf: [ "SERVICE" ] | ||
- attribute: rpc.service | ||
anyOf: [ "Firehose" ] | ||
Comment on lines
14
to
15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What instrumentation are you using for firehose? I cannot find any conventions for firehose. |
||
- attribute: cloud.resource_id | ||
regex: "^arn:aws:firehose:([^:]*):([^:]*):deliverystream/([^:]*)" | ||
relationship: | ||
expires: P75M | ||
relationshipType: CALLS | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,13 +3,18 @@ relationships: | |
version: "1" | ||
origins: | ||
- Distributed Tracing | ||
- OpenTelemetry | ||
conditions: | ||
- attribute: eventType | ||
anyOf: [ "Span" ] | ||
- attribute: instrumentation.provider | ||
anyOf: [ "opentelemetry" ] | ||
- attribute: newrelic.source | ||
anyOf: [ "api.traces.otlp" ] | ||
- attribute: entity.type | ||
anyOf: [ "SERVICE" ] | ||
- attribute: rpc.service | ||
anyOf: [ "kinesis" ] | ||
Comment on lines
14
to
15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What instrumentation are you using for kinesis? I cannot find any conventions for kinesis. |
||
- attribute: cloud.resource_id | ||
regex: "^arn:aws:kinesis:([^:]*):([^:]*):stream/([^:]*)" | ||
relationship: | ||
expires: P75M | ||
relationshipType: CALLS | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,13 +3,18 @@ relationships: | |
version: "1" | ||
origins: | ||
- Distributed Tracing | ||
- OpenTelemetry | ||
conditions: | ||
- attribute: eventType | ||
anyOf: [ "Span" ] | ||
- attribute: instrumentation.provider | ||
anyOf: [ "opentelemetry" ] | ||
- attribute: newrelic.source | ||
anyOf: [ "api.traces.otlp" ] | ||
- attribute: entity.type | ||
anyOf: [ "SERVICE" ] | ||
- attribute: rpc.service | ||
anyOf: [ "Redshift" ] | ||
Comment on lines
14
to
15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What instrumentation are you using for Redshift that sets |
||
- attribute: server.address | ||
regex: '^[a-zA-Z0-9\-]+\.[a-z0-9]+\.[a-zA-Z0-9\-]+\.redshift\.amazonaws\.com$' | ||
relationship: | ||
expires: P75M | ||
relationshipType: CALLS | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What instrumentation are you using for DynamoDB that sets
rpc.service=DynamoDB
?