Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update attributes as per semantic convention and add more conditions #1906

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
91a69df
feat: Added kiness delivery stream
vinaykonatala Oct 25, 2024
c0a0e4f
Merge pull request #1 from vinaykonatala/NR-330033
vinaykonatala Oct 28, 2024
ca29b24
feat: Added relationship condition
vinaykonatala Oct 29, 2024
2423b3f
feat: Added relationship condition
vinaykonatala Oct 29, 2024
233e9a5
fix: Added apm kinesis relation file
vinaykonatala Oct 29, 2024
bce08df
fix:Removed apm relation file
vinaykonatala Oct 29, 2024
d2dd934
fix: Add new condition
vinaykonatala Nov 12, 2024
122b600
fix: Added quotes in array
vinaykonatala Nov 13, 2024
f3ab1ef
Merge branch 'main' into main
vinaykonatala Nov 13, 2024
9f6acf4
fix: Updated the tagkeys
vinaykonatala Nov 18, 2024
ac8ccb7
Merge branch 'main' of https://github.com/vinaykonatala/entity-defini…
vinaykonatala Nov 18, 2024
1002c5a
Merge branch 'main' into main
vinaykonatala Nov 18, 2024
0a78548
Merge branch 'main' into main
otaviocarvalho Nov 19, 2024
a128745
Merge branch 'newrelic:main' into main
vinaykonatala Nov 28, 2024
b6cc28d
Merge branch 'newrelic:main' into main
vinaykonatala Dec 10, 2024
592d791
Merge branch 'newrelic:main' into main
vinaykonatala Dec 12, 2024
ee47b4b
Merge branch 'newrelic:main' into main
vinaykonatala Dec 12, 2024
e2307e3
Merge branch 'newrelic:main' into main
vinaykonatala Dec 19, 2024
5d979bb
Merge branch 'newrelic:main' into main
vinaykonatala Jan 10, 2025
496939f
Merge branch 'newrelic:main' into main
vinaykonatala Jan 16, 2025
07515e1
Merge branch 'newrelic:main' into main
vinaykonatala Jan 22, 2025
c4589c5
Merge branch 'newrelic:main' into main
vinaykonatala Jan 29, 2025
bed8f1a
Merge branch 'newrelic:main' into main
vinaykonatala Jan 31, 2025
b6ef51f
Merge branch 'newrelic:main' into main
vinaykonatala Feb 7, 2025
ad85d46
Merge branch 'newrelic:main' into main
vinaykonatala Feb 10, 2025
7f32fef
fix: Added support semantic convention
vinaykonatala Feb 10, 2025
830c5c2
fix: Fixed build space issue
vinaykonatala Feb 10, 2025
085d332
fix: Added origin as opentelemetry
vinaykonatala Feb 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,18 @@ relationships:
version: "1"
origins:
- Distributed Tracing
- OpenTelemetry
conditions:
- attribute: eventType
anyOf: [ "Span"]
- attribute: newrelic.source
anyOf: [ "api.traces.otlp" ]
- attribute: entity.type
anyOf: [ "SERVICE" ]
- attribute: rpc.service
anyOf: [ "Lambda" ]
- attribute: cloud.resource_id
regex: "^arn:aws:lambda:([^:]*):([^:]*):function:([^:]*):([^/]*)$"
relationship:
expires: P75M
relationshipType: CALLS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,16 @@ relationships:
version: "1"
origins:
- Distributed Tracing
- OpenTelemetry
conditions:
- attribute: eventType
anyOf: [ "Span" ]
- attribute: newrelic.source
anyOf: [ "api.traces.otlp" ]
- attribute: entity.type
anyOf: [ "SERVICE" ]
- attribute: cloud.resource_id
regex: "^arn:aws:dynamodb:([^:]*):([^:]*):table/([^/]*)$"
- attribute: rpc.service
anyOf: [ "DynamoDB" ]
Comment on lines 16 to 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What instrumentation are you using for DynamoDB that sets rpc.service=DynamoDB?

relationship:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@ relationships:
version: "1"
origins:
- Distributed Tracing
- OpenTelemetry
conditions:
- attribute: eventType
anyOf: [ "Span" ]
- attribute: instrumentation.provider
anyOf: [ "opentelemetry" ]
- attribute: newrelic.source
anyOf: [ "api.traces.otlp" ]
- attribute: entity.type
anyOf: [ "SERVICE" ]
- attribute: rpc.service
anyOf: [ "Firehose" ]
Comment on lines 14 to 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What instrumentation are you using for firehose? I cannot find any conventions for firehose.

- attribute: cloud.resource_id
regex: "^arn:aws:firehose:([^:]*):([^:]*):deliverystream/([^:]*)"
relationship:
expires: P75M
relationshipType: CALLS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@ relationships:
version: "1"
origins:
- Distributed Tracing
- OpenTelemetry
conditions:
- attribute: eventType
anyOf: [ "Span" ]
- attribute: instrumentation.provider
anyOf: [ "opentelemetry" ]
- attribute: newrelic.source
anyOf: [ "api.traces.otlp" ]
- attribute: entity.type
anyOf: [ "SERVICE" ]
- attribute: rpc.service
anyOf: [ "kinesis" ]
Comment on lines 14 to 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What instrumentation are you using for kinesis? I cannot find any conventions for kinesis.

- attribute: cloud.resource_id
regex: "^arn:aws:kinesis:([^:]*):([^:]*):stream/([^:]*)"
relationship:
expires: P75M
relationshipType: CALLS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@ relationships:
version: "1"
origins:
- Distributed Tracing
- OpenTelemetry
conditions:
- attribute: eventType
anyOf: [ "Span" ]
- attribute: instrumentation.provider
anyOf: [ "opentelemetry" ]
- attribute: newrelic.source
anyOf: [ "api.traces.otlp" ]
- attribute: entity.type
anyOf: [ "SERVICE" ]
- attribute: rpc.service
anyOf: [ "Redshift" ]
Comment on lines 14 to 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What instrumentation are you using for Redshift that sets rpc.service=Redshift?

- attribute: server.address
regex: '^[a-zA-Z0-9\-]+\.[a-z0-9]+\.[a-zA-Z0-9\-]+\.redshift\.amazonaws\.com$'
relationship:
expires: P75M
relationshipType: CALLS
Expand Down