fix: Update attributes as per semantic convention and add more conditions #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Adding candidate and relationship btw OTel and kiness delivery stream
entityBot
approved these changes
Feb 10, 2025
entityBot
approved these changes
Feb 10, 2025
entityBot
approved these changes
Feb 10, 2025
entityBot
approved these changes
Feb 10, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
entityBot
approved these changes
Feb 10, 2025
entityBot
approved these changes
Feb 10, 2025
alanwest
reviewed
Feb 12, 2025
Comment on lines
16
to
17
| - attribute: rpc.service | ||
| anyOf: [ "DynamoDB" ] |
There was a problem hiding this comment.
What instrumentation are you using for DynamoDB that sets rpc.service=DynamoDB?
Comment on lines
14
to
15
| - attribute: rpc.service | ||
| anyOf: [ "Redshift" ] |
There was a problem hiding this comment.
What instrumentation are you using for Redshift that sets rpc.service=Redshift?
Comment on lines
14
to
15
| - attribute: rpc.service | ||
| anyOf: [ "kinesis" ] |
There was a problem hiding this comment.
What instrumentation are you using for kinesis? I cannot find any conventions for kinesis.
Comment on lines
14
to
15
| - attribute: rpc.service | ||
| anyOf: [ "Firehose" ] |
There was a problem hiding this comment.
What instrumentation are you using for firehose? I cannot find any conventions for firehose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Checklist
identifierwill be unique and valid.