Skip to content

test: remove node-fetch references in zisi package #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

test: remove node-fetch references in zisi package #6382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42fea1d
test: remove node-fetch references in zisi package
mrstork May 23, 2025
bc80f60
Merge branch 'main' into zisi-remove-node-fetch
mrstork May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/zip-it-and-ship-it/tests/fixtures/node-fetch/function.js
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/zip-it-and-ship-it/tests/fixtures/node-fetch/node_modules/node-fetch/lib/index.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/zip-it-and-ship-it/tests/fixtures/node-fetch/node_modules/node-fetch/lib/index.mjs
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions packages/zip-it-and-ship-it/tests/fixtures/node-fetch/node_modules/node-fetch/package.json
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions packages/zip-it-and-ship-it/tests/fixtures/node-fetch/package.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions packages/zip-it-and-ship-it/tests/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,18 +896,6 @@ describe('zip-it-and-ship-it', () => {
},
)

testMany(
'Exposes the main export of `node-fetch` when imported using `require()`',
[...allBundleConfigs],
Comment on lines -899 to -901
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, it took me a few hops to find this but here's where this was introduced: netlify/zip-it-and-ship-it#353. I'm a little worried that I don't fully understand the intent of this, so maybe we should wait for a thumbs up from @eduardoboucas on this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... although it's just removing a test, so I'll approve and we can always revert if necessary!

async (options) => {
const { files } = await zipFixture('node-fetch', { opts: options })
const unzippedFunctions = await unzipFiles(files)
const returnValue = await importFunctionFile(`${unzippedFunctions[0].unzipPath}/function.js`)

expect(returnValue).toBeTypeOf('function')
},
)

testMany(
'{name}/{name}.js takes precedence over {name}.js and {name}/index.js',
[...allBundleConfigs, 'bundler_none'],
Expand Down
Loading