test: remove node-fetch references in zisi package #6382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
reviewed
May 26, 2025
Comment on lines
-899
to
-901
| testMany( | ||
| 'Exposes the main export of `node-fetch` when imported using `require()`', | ||
| [...allBundleConfigs], |
There was a problem hiding this comment.
Whew, it took me a few hops to find this but here's where this was introduced: netlify/zip-it-and-ship-it#353. I'm a little worried that I don't fully understand the intent of this, so maybe we should wait for a thumbs up from @eduardoboucas on this one.
There was a problem hiding this comment.
... although it's just removing a test, so I'll approve and we can always revert if necessary!
serhalp
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we use node >18 we can drop the node-fetch polyfill from the package
Part of FRB-1833
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)