Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude deleted devices from Deployment device counts #1735

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

joshk
Copy link
Collaborator

@joshk joshk commented Jan 7, 2025

Missed this one from an earlier PR

@joshk joshk requested review from lawik and nshoes January 7, 2025 10:48
Copy link
Contributor

@nshoes nshoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a LiveView test for this?

@joshk
Copy link
Collaborator Author

joshk commented Jan 7, 2025

Can we get a LiveView test for this?

fiiiiiiiiiiiine

@joshk joshk requested review from lawik and nshoes January 7, 2025 21:12
@joshk joshk merged commit 42320dc into main Jan 7, 2025
2 checks passed
@joshk joshk deleted the another-device-count-fix branch January 7, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants