Exclude deleted devices from Deployment device counts (#1735)

Missed this one from an earlier PR

lib/nerves_hub/deployments.ex

@@ -35,6 +35,7 @@ defmodule NervesHub.Deployments do
     |> select([d], {d.deployment_id, count(d.id)})
     |> where([d], d.product_id == ^product_id)
     |> group_by([d], d.deployment_id)
+    |> Repo.exclude_deleted()
     |> Repo.all()
     |> Map.new()
   end

test/nerves_hub_web/live/deployments/index_test.exs

@@ -1,6 +1,8 @@
 defmodule NervesHubWeb.Live.Deployments.IndexTest do
   use NervesHubWeb.ConnCase.Browser, async: true
 
+  alias NervesHub.Deployments
+  alias NervesHub.Devices
   alias NervesHub.Fixtures
 
   test "no deployments", %{conn: conn, user: user, org: org} do
@@ -16,5 +18,36 @@ defmodule NervesHubWeb.Live.Deployments.IndexTest do
     |> visit("/org/#{org.name}/#{product.name}/deployments")
     |> assert_has("h1", text: "Deployments")
     |> assert_has("a", text: deployment.name)
+    |> assert_has("td div", text: "0")
+  end
+
+  test "device counts don't include deleted devices", %{
+    conn: conn,
+    org: org,
+    product: product,
+    deployment: deployment,
+    device: device
+  } do
+    conn
+    |> visit("/org/#{org.name}/#{product.name}/deployments")
+    |> assert_has("h1", text: "Deployments")
+    |> assert_has("a", text: deployment.name)
+    |> assert_has("td div", text: "0")
+
+    Deployments.set_deployment(device)
+
+    conn
+    |> visit("/org/#{org.name}/#{product.name}/deployments")
+    |> assert_has("h1", text: "Deployments")
+    |> assert_has("a", text: deployment.name)
+    |> assert_has("td div", text: "1")
+
+    Devices.delete_device(device)
+
+    conn
+    |> visit("/org/#{org.name}/#{product.name}/deployments")
+    |> assert_has("h1", text: "Deployments")
+    |> assert_has("a", text: deployment.name)
+    |> assert_has("td div", text: "0")
   end
 end