Skip to content

feat: Add make_sample() function to WoodburyKernel_varNP and remove params … #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meyers-academic merged 1 commit into from
Mar 5, 2026
Merged

feat: Add make_sample() function to WoodburyKernel_varNP and remove params … #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/discovery/matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,21 @@ class WoodburyKernel_varNP(VariableKernel):
def __init__(self, N_var, F, P_var):
self.N_var, self.F, self.P_var = N_var, F, P_var

def make_sample(self):
N_sample = self.N_var.make_sample()
P_sample = self.P_var.make_sample()
F = jnparray(self.F)

def sample(key, params):
key, n = N_sample(key, params)
key, c = P_sample(key, params)

return key, n + jnp.dot(F, c)

sample.params = sorted(set(N_sample.params + P_sample.params))

return sample

def make_kernelproduct_vary(self, y):
y_var = y

Expand Down Expand Up @@ -1725,7 +1740,7 @@ def __init__(self, N_var, F, P):
self.Pinv, self.ldP = P.inv()
self.params = N_var.params

def make_sample(self, params):
def make_sample(self):
N_sample = self.N_var.make_sample()
P_sample = self.P.make_sample()
F = jnparray(self.F)
Expand Down
Loading