feat: Add make_sample() function to WoodburyKernel_varNP and remove params …#122
Merged
meyers-academic merged 1 commit intonanograv:mainfrom Mar 5, 2026
Merged
Conversation
…from make_sample() in WoodburyKernel_varN
Collaborator
|
Thanks! I will try to look at this before the end of the week. yes, For |
meyers-academic
approved these changes
Mar 5, 2026
Collaborator
meyers-academic
left a comment
There was a problem hiding this comment.
This looks great, thank you for catching the bug and for adding this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…from make_sample() in WoodburyKernel_varN
This PR adds a
make_sample()function to theWoodburyKernel_varNP. The issue arose when I was trying to follow the simulations.rst tutorial given within discovery. When runningparams = ds.sample_uniform(sampler.params), I got errorAttributeError: 'WoodburyKernel_varNP' object has no attribute 'make_sample'.Further,
make_sample(self, params)inWoodburyKernel_varNtakes inparamsargument which differs from all othermake_sample()functions inmatrix.py. This raises errorTypeError: WoodburyKernel_varN.make_sample() missing 1 required positional argument: 'params'. This PR removes params from the argument ofmake_paramsinWoodburyKernel_varN.After changing these two, the simulation code is running successfully.
Please let me know if any modifications are necessary.