Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data race #4 #6069

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Data race #4 #6069

merged 1 commit into from
Aug 30, 2024

Conversation

Zensey
Copy link
Contributor

@Zensey Zensey commented Jul 29, 2024

Resolves: #6060

Note:

github.com/mysteriumnetwork/node/core/service.(*Instance).proposalWithCurrentLocation()
github.com/mysteriumnetwork/node/tequilapi/endpoints.(*ServiceEndpoint).toServiceInfoResponse()

The 2 methods, which trigger a race are not public and are in different packages, that's why making a unit-test is not possible.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.47%. Comparing base (3174272) to head (aef5b00).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6069      +/-   ##
==========================================
- Coverage   37.92%   28.47%   -9.46%     
==========================================
  Files         371      520     +149     
  Lines       20715    29963    +9248     
==========================================
+ Hits         7856     8531     +675     
- Misses      12075    20607    +8532     
- Partials      784      825      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zensey Zensey force-pushed the fix/datarace4 branch 2 times, most recently from b3be6e5 to 65b28b3 Compare July 30, 2024 08:46
Copy link

stale bot commented Aug 15, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 15, 2024
@stale stale bot removed the stale label Aug 30, 2024
@Zensey Zensey merged commit 7337b84 into master Aug 30, 2024
19 checks passed
@Zensey Zensey deleted the fix/datarace4 branch August 30, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race
4 participants