Merge pull request #6069 from mysteriumnetwork/fix/datarace4

Data race #4
mysteriumnetwork · Aug 30, 2024 · 7337b84 · 7337b84
2 parents 5938d83 + aef5b00
commit 7337b84
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/tequilapi/endpoints/service.go b/tequilapi/endpoints/service.go
@@ -352,6 +352,12 @@ func (se *ServiceEndpoint) toServiceOptions(serviceType string, value *json.RawM
 }
 
 func (se *ServiceEndpoint) toServiceInfoResponse(id service.ID, instance *service.Instance) (contract.ServiceInfoDTO, error) {
+
+	// Warning.
+	// Use only safely obtained copy of instance.Proposal field, otherwise concurrent
+	// access to that field from Instance.proposalWithCurrentLocation
+	// can trigger a data race
+
 	priced, err := se.proposalRepository.EnrichProposalWithPrice(instance.CopyProposal())
 	if err != nil {
 		return contract.ServiceInfoDTO{}, err