Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(refactor): drop duplicated shutdown logics #3589

Merged
merged 3 commits into from
Sep 17, 2024
Merged

chore(refactor): drop duplicated shutdown logics #3589

merged 3 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. chore(refactor): drop duplicated shutdown logics 

    - Handle locking in Shutdown and CheckModelIsLoaded in a more go-idiomatic way
- Drop duplicated code and re-organize shutdown code

Signed-off-by: Ettore Di Giacinto <[email protected]>
    @mudler
    mudler committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b2be271 View commit details
    Browse the repository at this point in the history

  2. fix: drop leftover 

    Signed-off-by: Ettore Di Giacinto <[email protected]>
    @mudler
    mudler committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c2bc2b2 View commit details
    Browse the repository at this point in the history

  3. chore: improve logging and add missing locks 

    Signed-off-by: Ettore Di Giacinto <[email protected]>
    @mudler
    mudler committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a6be6fe View commit details
    Browse the repository at this point in the history