Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): drop duplicated shutdown logics #3589

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

mudler
Copy link
Owner

@mudler mudler commented Sep 17, 2024

Description

  • Handle locking in Shutdown and CheckModelIsLoaded in a more go-idiomatic way
  • Drop duplicated code and re-organize shutdown code

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

- Handle locking in Shutdown and CheckModelIsLoaded in a more go-idiomatic way
- Drop duplicated code and re-organize shutdown code

Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit a6be6fe
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/66e98aea3d6a2d0008343d1e
😎 Deploy Preview https://deploy-preview-3589--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mudler mudler merged commit a53392f into master Sep 17, 2024
28 of 30 checks passed
@mudler mudler deleted the ref/shutdown branch September 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants