Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchedMesh: Deprecate old instancing render paths #30550

Merged
merged 4 commits into from
Feb 18, 2025
Merged

BatchedMesh: Deprecate old instancing render paths #30550

merged 4 commits into from
Feb 18, 2025

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #29655

Description

Follow up to #29655. Deprecates use of _multiDrawInstances for BatchedMesh.

cc @CodyJasonBennett @RenaudRohlinger

@gkjohnson gkjohnson added this to the r174 milestone Feb 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.36
78.33		 336.51
78.38		 +157 B
+57 B
WebGPU 518.88
144.01		 519.2
144.16		 +327 B
+150 B
WebGPU Nodes 518.34
143.9		 518.67
144.05		 +327 B
+152 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.35
112.17		 465.51
112.23		 +158 B
+60 B
WebGPU 590.71
159.97		 591.03
160.12		 +327 B
+150 B
WebGPU Nodes 546.01
149.44		 546.34
149.59		 +327 B
+150 B

@gkjohnson gkjohnson merged commit 97a078d into mrdoob:dev Feb 18, 2025
12 checks passed
@gkjohnson gkjohnson deleted the deprecate-draw-instances branch February 18, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

@RenaudRohlinger RenaudRohlinger Awaiting requested review from RenaudRohlinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r174
Development

Successfully merging this pull request may close these issues.
2 participants
@gkjohnson @Mugen87