Improved TypeScript declarations for userProperties #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userProperties changed from being object to being {[index: string]: string} (name-value string pairs)
|
UserProperty can be an array, because by mqtt5 specification each userProperty can be few times in one packet. So your declaration is wrong. So it have two forms: {[index: string]: string} and {[index: string]: Array} |
|
@scarry1992, changed to allow for the array. I also wanted to make a PR on MQTT.js to use this but it would be dependent on an version of mqtt-packet with this change in it. How do you manage that scenario? |
scarry1992
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userProperties changed from being object to being {[index: string]: string} (name-value string pairs)
fixes #102