Improved TypeScript declarations for userProperties #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userProperties changed from being object to being {[index: string]: string[]} (name-value string pairs)
Also changed OnConnectCallback and OnMessageCallback to use IConnectPacket and IPublishPacket respectively. These are the specific packets relevant to these callbacks rather than the more generic Packet.
NB Also changed package.json to link to version of mqtt-packet with the equivalent changes which are required. This needs to be updated prior to Pulling.
dealt with in separate PR
changes to client.d.ts to fix missing event types and also to specifically refer to specific packet types rather than the generic 'Packet'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userProperties changed from being object to being {[index: string]: string[]} (name-value string pairs)
fixes #1248
Not all tests are passing, but same test fail as on Master