Record reasoning and private_notes separately in Content Decisions
#23419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
force-pushed
the
keep-cinder-decision-notes-private
branch
from
a095724 to
2490333
Compare
- `reasoning` is the comment sent to the content owner (or reporter for a reporter appeal). - `private_notes` are, as the name implies, private notes entered by the moderator, and not shared externally. For consistency and to keep existing data, since we had already shared existing `notes` externally, the `notes` field has been renamed to `reasoning` and a new `private_notes` field has been introduced. When private notes are entered for a decision that goes through ContentAction.log_action(), record a separate activity for it, mimic what we do in reviewer tools in that case.
diox
force-pushed
the
keep-cinder-decision-notes-private
branch
from
66f163b to
1408ff7
Compare
eviljeff
approved these changes
May 13, 2025
| @@ -218,7 +218,9 @@ def handle_escalate_action(*, job_pk, from_2nd_level=False): | |||
| old_job.target, resolved_in_reviewer_tools=True | |||
| ) | |||
| job_id = entity_helper.workflow_recreate( | |||
| notes=old_job.final_decision.notes, job=old_job, from_2nd_level=from_2nd_level | |||
| reasoning=old_job.final_decision.reasoning, | |||
There was a problem hiding this comment.
Maybe not worth addressing, because #23338 removes this function, but the reasoning here would be from private_notes because it's via Cinder from taskus moderators.
I don't think it's possible at the moment, but in case that ever happens the code should handle it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change:
reasoningis the comment sent to the content owner (or reporter for a reporter appeal).private_notesare, as the name implies, private notes entered by the moderator, and not shared externally.That clear separation makes it possible for us to keep notes entered by moderators in Cinder private instead of exposing them as the reasoning.
For consistency and to keep existing data, since we had already shared existing
notesexternally, thenotesfield has been renamed toreasoningand a newprivate_notesfield has been introduced.Fixes mozilla/addons#15554