Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [Clean up] Dead code #23380

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Remove [Clean up] Dead code #23380

merged 1 commit into from
Nov 25, 2024

Conversation

lmarceau
Copy link
Contributor

📜 Tickets

No ticket

💡 Description

I tried using a tool called Periphery to locate some unused classes in the project + some unused import.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner November 25, 2024 19:50
Copy link
Contributor

@Cramsden Cramsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.61%
📖 Edited 14 files
📖 Created 0 files

Client.app: Coverage: 31.58

File Coverage
AddressAutofillCoordinator.swift 59.63%
BookmarksCoordinator.swift 30.82% ⚠️
HistoryPanel.swift 34.73% ⚠️
LibraryPanelViewState.swift 18.0% ⚠️
PocketProvider.swift 86.81%
Clearables.swift 4.2% ⚠️
BookmarkItemsHelper.swift 100.0%
HistoryPanelViewModel.swift 84.46%
SceneCoordinator.swift 97.27%
BreachAlertsClient.swift 0.0% ⚠️
RustSyncManager.swift 25.95% ⚠️
SceneDelegate.swift 0.0% ⚠️
BreachAlertsManager.swift 50.6%

CredentialProvider.appex: Coverage: 21.19

File Coverage
RustSyncManager.swift 25.95% ⚠️

NotificationService.appex: Coverage: 25.95

File Coverage
RustSyncManager.swift 25.95% ⚠️

ShareTo.appex: Coverage: 31.47

File Coverage
RustSyncManager.swift 25.95% ⚠️

Generated by 🚫 Danger Swift against 89cc510

@lmarceau lmarceau merged commit 273cbdb into main Nov 25, 2024
8 of 10 checks passed
@lmarceau lmarceau deleted the lm/clean-up-classes branch November 25, 2024 20:19
@lmarceau lmarceau mentioned this pull request Dec 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants