Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FXIOS Unused code #23543

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove FXIOS Unused code #23543

wants to merge 4 commits into from

Conversation

lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Dec 3, 2024

📜 Tickets

No tickets

💡 Description

I tried using a tool called Periphery to locate some unused classes in the project. This is a follow up on #23380

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner December 3, 2024 20:04
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.43%
📖 Edited 7 files
📖 Created 0 files

Client.app: Coverage: 31.47

File Coverage
UIWindow+Extension.swift 100.0%
UIViewController+Extension.swift 8.54% ⚠️
UIPasteboard+Extension.swift 35.29% ⚠️
TabLocationView.swift 41.91% ⚠️
UIDevice+Extension.swift 85.71%

Generated by 🚫 Danger Swift against 5407fec

Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 so nice when there is dead code removed

Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Not sure how useful it would be, but I think it would be nice to have this run on our CI and warn that we are pushing some unused code ?

@FilippoZazzeroni
Copy link
Collaborator

Yes @issammani that would be really nice to have on our CI, or to have a Github action who runs this every fixed amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants