-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MTE-1776 [v120] CopiedLinksTests and SettingsTests with TR #16930
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| // This Source Code Form is subject to the terms of the Mozilla Public | ||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/ | ||
|
|
||
| import XCTest | ||
|
|
||
| class SettingsTests: BaseTestCase { | ||
| // https://testrail.stage.mozaws.net/index.php?/cases/view/2334757 | ||
| func testHelpOpensSUMOInTab() { | ||
| navigator.nowAt(NewTabScreen) | ||
| navigator.goto(SettingsScreen) | ||
| let settingsTableView = app.tables[AccessibilityIdentifiers.Settings.tableViewController] | ||
|
|
||
| while settingsTableView.staticTexts["Help"].exists == false { | ||
| settingsTableView.swipeUp() | ||
| } | ||
| let helpMenu = settingsTableView.cells["Help"] | ||
| XCTAssertTrue(helpMenu.isEnabled) | ||
| helpMenu.tap() | ||
|
|
||
| waitUntilPageLoad() | ||
| mozWaitForValueContains(app.textFields["url"], value: "support.mozilla.org") | ||
| mozWaitForElementToExist(app.webViews.staticTexts["Firefox for iOS Support"]) | ||
|
|
||
| let numTabs = app.buttons["Show Tabs"].value | ||
| XCTAssertEqual("2", numTabs as? String, "Sume should be open in a different tab") | ||
| } | ||
|
|
||
| // https://testrail.stage.mozaws.net/index.php?/cases/view/2334760 | ||
| func testOpenSiriOption() { | ||
| waitForTabsButton() | ||
| navigator.nowAt(NewTabScreen) | ||
| navigator.performAction(Action.OpenSiriFromSettings) | ||
| mozWaitForElementToExist(app.cells["SiriSettings"], timeout: 5) | ||
| } | ||
|
|
||
| // https://testrail.stage.mozaws.net/index.php?/cases/view/2334756 | ||
| func testCopiedLinks() { | ||
| navigator.nowAt(NewTabScreen) | ||
| navigator.goto(SettingsScreen) | ||
|
|
||
| // Check Offer to open copied links, when opening firefox is off | ||
| let value = app.tables.cells.switches["Offer to Open Copied Links, When Opening Firefox"].value | ||
| XCTAssertEqual(value as? String, "0") | ||
|
|
||
| // Switch on, Offer to open copied links, when opening firefox | ||
| app.tables.cells.switches["Offer to Open Copied Links, When Opening Firefox"].tap() | ||
|
|
||
| // Check Offer to open copied links, when opening firefox is on | ||
| let value2 = app.tables.cells.switches["Offer to Open Copied Links, When Opening Firefox"].value | ||
| XCTAssertEqual(value2 as? String, "1") | ||
|
|
||
| app.navigationBars["Settings"].buttons["Done"].tap() | ||
|
|
||
| app.buttons[AccessibilityIdentifiers.Toolbar.settingsMenuButton].tap() | ||
| let settingsmenuitemCell = app.tables.otherElements["Settings"] | ||
| settingsmenuitemCell.tap() | ||
|
|
||
| // Check Offer to open copied links, when opening firefox is on | ||
| let value3 = app.tables.cells.switches["Offer to Open Copied Links, When Opening Firefox"].value | ||
| XCTAssertEqual(value3 as? String, "1") | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: is this on purpose? I think we could remove this test suite... the test is disabled and with the new way it works (opening the app 5 times before this message is shown) I'm not sure it will be enabled back soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an area that is not that easy to be automated and i agree i dont think it will be enabled soon. I will remove it.