Refactor MTE-1776 [v120] CopiedLinksTests and SettingsTests with TR #16930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 9461548 |
isabelrios
reviewed
Oct 19, 2023
| @@ -2,37 +2,12 @@ | |||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/ | |||
|
|
|||
| import XCTest | |||
| import Foundation | |||
There was a problem hiding this comment.
Nit: is this on purpose? I think we could remove this test suite... the test is disabled and with the new way it works (opening the app 5 times before this message is shown) I'm not sure it will be enabled back soon
There was a problem hiding this comment.
This is an area that is not that easy to be automated and i agree i dont think it will be enabled soon. I will remove it.
dragosb01
force-pushed
the
dbigu/MTE-1776
branch
from
286e39c to
a42186c
Compare
dragosb01
force-pushed
the
dbigu/MTE-1776
branch
from
a42186c to
9461548
Compare
dragosb01
had a problem deploying
to
github-pages
GitHub Actions
Failure
isabelrios
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
[Jira ticket](https://mozilla-hub.atlassian.net/browse/MTE-1776, https://mozilla-hub.atlassian.net/browse/MTE-1777)
💡 Description
Data alignment for CopiedLinksTests and SettingsTests with TestRail.
https://testrail.stage.mozaws.net/index.php?/suites/view/45443&group_by=cases:section_id&group_id=437096&group_order=asc
https://docs.google.com/document/d/1ddsPQpbQ7PkHzqrraDcpSKU9R4KnrlCTn1IfhgtwuUE/edit
https://docs.google.com/document/d/1VgYqGDQgZ-JLKu4gPrGCOqEvYpNbBkJI9gBEtDnqFCU/edit