-
Notifications
You must be signed in to change notification settings - Fork 81
iMC changes outside of storm-pars #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Does this depend on #588? That PR is still not ready for merging, is it? |
It doesn’t depend on that PR I‘m pretty sure, because that PR (mainly) changes things in storm-pars. The open discussion was about the behavior of the CLI flag but that is definitely in storm-pars. |
Ok, I see that there are indeed some changes outside of storm-pars in there, but those are not under discussion :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work!
I think some test cases for the robust mec decomposition and the scheduler tracking for robust value iteration would help with maintaining the new features.
If we agree to postpone these last two things (we've agreed on the end component decomposition refactoring but not yet on the SMT solver interfaces), we can merge this PR. Currently, the only place where SMT results are rounded are after big-step preprocessing. The changes to fix the SMT solver APIs are a lot of source code changes, but very doable later. See issue #713. |
seems that spot is failing :( |
Draft PR containing all changes I made for iMC algorithms that are outside of
storm-pars
. Tests in the storm-pars part (no PR for this yet) cover most lines in this PR.In more detail, this PR contains:
FlexibleSparseMatrix
that adds new rowsSchedulerTrackingHelper
for iMCs and a interval (=robust) scheduler index in the minmax solvers for warm-starting(Iterative)MinMaxLinearEquationSolver
addNotCurrentModel
function for SMT solvers that adds the constraint that the current model is not a solutionRobustMaximalEndComponentDecomposition
,RobustMaximalEndComponent
)ValueIterationOperator
for iMCsstorm::Interval